docs(openspec): 封存 worker mapping lineage 基線 - #30
Merged
monkey1sai merged 1 commit intoMay 12, 2026
Merged
monkey1sai merged 1 commit into
monkey1sai merged 1 commit into
Conversation
Contributor
📝 WalkthroughWalkthroughThis PR archives the ChangesWorker Lineage and Quality Baseline Integration
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@openspec/specs/runtime-verification-evidence/spec.md`:
- Around line 164-165: The spec uses minimum_coverage_locked in multiple places
but the artifact pipeline spec expects minimum_coverage_baseline_locked; update
the spec to use the unified field name minimum_coverage_baseline_locked
everywhere (e.g., the evidence record description that currently lists
minimum_coverage_locked, and the other occurrence around line 183) so the
evidence payloads and UI parsers are consistent with the artifact pipeline
contract; ensure the related sentence that lists fields still reads correctly
(minimum_coverage_baseline_locked=true, minimum_coverage_ratio=1.0,
coverage_denominator=source_ifc_entity_count, per-fixture metrics, and batch
status as passed).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5ebb2394-f226-4848-b9b6-28958957528c
📒 Files selected for processing (12)
docs/plans/AI-BIM-governance-saas-roadmap-2026-05.htmldocs/plans/AI-BIM-governance-saas-roadmap-2026-05.mdopenspec/changes/archive/2026-05-12-worker-mapping-lineage-quality-baseline/.openspec.yamlopenspec/changes/archive/2026-05-12-worker-mapping-lineage-quality-baseline/design.mdopenspec/changes/archive/2026-05-12-worker-mapping-lineage-quality-baseline/proposal.mdopenspec/changes/archive/2026-05-12-worker-mapping-lineage-quality-baseline/specs/runtime-verification-evidence/spec.mdopenspec/changes/archive/2026-05-12-worker-mapping-lineage-quality-baseline/specs/worker-artifact-pipeline/spec.mdopenspec/changes/archive/2026-05-12-worker-mapping-lineage-quality-baseline/specs/worker-demo-upload-convert-ui/spec.mdopenspec/changes/archive/2026-05-12-worker-mapping-lineage-quality-baseline/tasks.mdopenspec/specs/runtime-verification-evidence/spec.mdopenspec/specs/worker-artifact-pipeline/spec.mdopenspec/specs/worker-demo-upload-convert-ui/spec.md
Comment on lines
+164
to
+165
| - **THEN** the evidence records `minimum_coverage_locked=true`, `minimum_coverage_ratio=1.0`, `coverage_denominator=source_ifc_entity_count`, per-fixture metrics, and the batch status as `passed` | ||
|
|
Contributor
There was a problem hiding this comment.
Unify baseline-lock field name across specs
Line 164 and Line 183 use minimum_coverage_locked=true, but the artifact pipeline spec defines the lock field as minimum_coverage_baseline_locked. This contract drift can break evidence/UI parsing and create incompatible payload expectations.
Proposed spec-alignment diff
- - **THEN** the evidence records `minimum_coverage_locked=true`, `minimum_coverage_ratio=1.0`, `coverage_denominator=source_ifc_entity_count`, per-fixture metrics, and the batch status as `passed`
+ - **THEN** the evidence records `minimum_coverage_baseline_locked=true`, `minimum_coverage_ratio=1.0`, `coverage_denominator=source_ifc_entity_count`, per-fixture metrics, and the batch status as `passed`
- - **THEN** the evidence records the issue identifier, IFC GUID, mapped USD prim path, conversion job ID, artifact group ID, and `minimum_coverage_locked=true`
+ - **THEN** the evidence records the issue identifier, IFC GUID, mapped USD prim path, conversion job ID, artifact group ID, and `minimum_coverage_baseline_locked=true`Also applies to: 183-183
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@openspec/specs/runtime-verification-evidence/spec.md` around lines 164 - 165,
The spec uses minimum_coverage_locked in multiple places but the artifact
pipeline spec expects minimum_coverage_baseline_locked; update the spec to use
the unified field name minimum_coverage_baseline_locked everywhere (e.g., the
evidence record description that currently lists minimum_coverage_locked, and
the other occurrence around line 183) so the evidence payloads and UI parsers
are consistent with the artifact pipeline contract; ensure the related sentence
that lists fields still reads correctly (minimum_coverage_baseline_locked=true,
minimum_coverage_ratio=1.0, coverage_denominator=source_ifc_entity_count,
per-fixture metrics, and batch status as passed).
Contributor
There was a problem hiding this comment.
Pull request overview
This PR archives the accepted OpenSpec change worker-mapping-lineage-quality-baseline by merging its delta requirements into the current authoritative specs under openspec/specs/, preserving the change artifacts under openspec/changes/archive/, and updating the SaaS roadmap (Markdown + generated HTML) to reflect the archived status and updated Phase 1 gaps.
Changes:
- Merge lineage API, all-IFC-entity coverage baseline policy, storage batch verification/evidence tier, and worker UI lineage/quality requirements into current OpenSpec specs.
- Add an archive snapshot folder for the accepted change (proposal/design/tasks + delta spec snapshots).
- Update the 2026-05 SaaS roadmap Markdown and regenerate the corresponding HTML to reflect the new archived state and next priorities.
Reviewed changes
Copilot reviewed 4 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| openspec/specs/worker-demo-upload-convert-ui/spec.md | Adds current-spec requirements for worker UI lineage + quality observability. |
| openspec/specs/worker-artifact-pipeline/spec.md | Incorporates lineage API contract, all-entity coverage baseline policy, and storage batch verification requirements. |
| openspec/specs/runtime-verification-evidence/spec.md | Incorporates storage batch evidence tier + issue-to-real-prim evidence prerequisites. |
| openspec/changes/archive/2026-05-12-worker-mapping-lineage-quality-baseline/tasks.md | Archives the change task checklist as historical record. |
| openspec/changes/archive/2026-05-12-worker-mapping-lineage-quality-baseline/specs/worker-demo-upload-convert-ui/spec.md | Stores delta snapshot of UI spec changes for the archived change. |
| openspec/changes/archive/2026-05-12-worker-mapping-lineage-quality-baseline/specs/worker-artifact-pipeline/spec.md | Stores delta snapshot of pipeline spec changes for the archived change. |
| openspec/changes/archive/2026-05-12-worker-mapping-lineage-quality-baseline/specs/runtime-verification-evidence/spec.md | Stores delta snapshot of evidence spec changes for the archived change. |
| openspec/changes/archive/2026-05-12-worker-mapping-lineage-quality-baseline/proposal.md | Archives the accepted change proposal. |
| openspec/changes/archive/2026-05-12-worker-mapping-lineage-quality-baseline/design.md | Archives the accepted change design decisions and rationale. |
| openspec/changes/archive/2026-05-12-worker-mapping-lineage-quality-baseline/.openspec.yaml | Adds archive metadata for the change folder. |
| docs/plans/AI-BIM-governance-saas-roadmap-2026-05.md | Updates roadmap narrative/status tables to reflect the archived change and updated next steps. |
| docs/plans/AI-BIM-governance-saas-roadmap-2026-05.html | Regenerates the HTML view to match the updated roadmap Markdown. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+161
to
+165
| #### Scenario: Full storage fixture batch passes | ||
|
|
||
| - **WHEN** all required `storage/*.ifc` fixtures complete real IFC->USDC conversion with openable USDC, truthful mapping output, lineage API success, and every source IFC entity mapped to at least one real USD prim path | ||
| - **THEN** the evidence records `minimum_coverage_locked=true`, `minimum_coverage_ratio=1.0`, `coverage_denominator=source_ifc_entity_count`, per-fixture metrics, and the batch status as `passed` | ||
|
|
| lineage API / UI / quality policy: implemented in change branch | ||
| lineage API / UI / quality policy: archived into current specs | ||
| _worker dependency baseline: requirements pin fastapi/starlette/uvicorn to repo baseline | ||
| canonical storage dry-run: 13 IFC fixtures found; not converted; minimum_coverage_locked=false |
| | **涵蓋原候選** | #3 `worker-artifact-lineage-api` + #3A `worker-mapping-quality-baseline` | | ||
| | **已併入 specs** | `worker-artifact-pipeline`、`runtime-verification-evidence`、`worker-demo-upload-convert-ui` | | ||
| | **已完成** | lineage graph API、stable mapping/index derived artifact IDs、worker UI lineage / quality view、all-IFC-entity coverage denominator、`minimum_coverage_ratio=1.0` policy、warn reviewable / fail blocking readiness、storage batch helper | | ||
| | **仍未宣稱完成** | canonical 13-file real batch 未完成；`minimum_coverage_locked=true` production baseline 與 issue → real prim verified evidence 尚未成立 | |
| 3. **下一個 worker 品質工作：補 canonical storage 13-file real batch evidence**： | ||
| - 使用 `C:\Repos\active\iot\AI-BIM-governance\storage\*.ifc` 作為正式本機 fixture root。 | ||
| - 先解決 89MB fixture `--limit 1` 超過 600s timeout 的 runtime / performance 問題，再擴到 13-file batch。 | ||
| - 只有全批次 real conversion、USDC openability、lineage API、all-IFC-entity coverage 都通過時，才可把 `minimum_coverage_locked=true` production baseline 寫入 evidence。 |
Comment on lines
+176
to
+184
| ### Requirement: Issue-to-real-prim evidence requires locked real mapping | ||
|
|
||
| Runtime verification evidence SHALL only classify issue-to-real-prim highlight baseline as verified when the worker mapping is real, coverage baseline is locked, and the highlighted prim path can be traced from an issue's IFC GUID through `element_mapping.json` to `primary_usd_prim_path` or `usd_prim_paths`. | ||
|
|
||
| #### Scenario: Issue highlight uses real mapping | ||
|
|
||
| - **WHEN** a reviewer or smoke test highlights an issue whose IFC GUID appears in real mapping output with a valid primary USD prim path | ||
| - **THEN** the evidence records the issue identifier, IFC GUID, mapped USD prim path, conversion job ID, artifact group ID, and `minimum_coverage_locked=true` | ||
|
|
monkey1sai
deleted the
codex/openspec/archive-worker-mapping-lineage-quality-baseline
branch
May 12, 2026 07:41
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a94cad6567
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| #### Scenario: Full storage fixture batch passes | ||
|
|
||
| - **WHEN** all required `storage/*.ifc` fixtures complete real IFC->USDC conversion with openable USDC, truthful mapping output, lineage API success, and every source IFC entity mapped to at least one real USD prim path | ||
| - **THEN** the evidence records `minimum_coverage_locked=true`, `minimum_coverage_ratio=1.0`, `coverage_denominator=source_ifc_entity_count`, per-fixture metrics, and the batch status as `passed` |
There was a problem hiding this comment.
This new evidence scenario writes minimum_coverage_locked=true, but the rest of the archived contract and worker payloads use minimum_coverage_baseline_locked (for example the conversion-quality requirement immediately above and worker-artifact-pipeline both name that field). If future batch evidence follows this scenario verbatim, downstream checks looking for the canonical field will not recognize the baseline as locked; the same shortened name also appears later in the issue-highlight scenario/roadmap and should be aligned.
Useful? React with 👍 / 👎.
|
|
||
| `_worker` SHALL provide an implementation path for batch quality verification over repo-local `storage/*.ifc` fixtures. The Windows local fixture glob `C:\Repos\active\iot\AI-BIM-governance\storage\*.ifc` and the worktree-local `_worker` dev source root `../storage` SHALL be treated as the same fixture source class for local validation. | ||
|
|
||
| The batch verification path MUST use existing worker artifact intake and selected-source conversion contracts unless a later production batch-job spec is opened. Each fixture result MUST record filename, relative path, size, source artifact ID, artifact group ID, conversion job ID, USDC openability, mapped count, unmapped count, coverage ratio, coverage status, lineage API status, duration when available, and failure or warning details. |
There was a problem hiding this comment.
The runtime-evidence spec now requires the storage batch tier to identify source_ifc_entity_count, minimum_coverage_ratio=1.0, and the baseline-lock state, but this worker batch contract only requires generic mapped/unmapped counts plus coverage status. If someone implements or validates against this spec alone, the batch summary can pass the worker contract while still being insufficient to prove the all-IFC-entity denominator or baseline-lock evidence required before declaring the production mapping baseline locked.
Useful? React with 👍 / 👎.
This was referenced May 13, 2026
monkey1sai
added a commit
that referenced
this pull request
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
變更摘要
封存
worker-mapping-lineage-quality-baselineOpenSpec change，將 lineage API、all-IFC-entity coverage policy、storage batch evidence tier 與 worker UI lineage / quality view 併入現行 specs，並同步更新 SaaS roadmap Markdown/HTML。修改原因
PR #29 已合併，依 OpenSpec workflow 需要在實作接受後把 delta specs 併入
openspec/specs/，再將 change artifacts 移入 archive，避免 roadmap 與現行 spec 目錄漂移。主要變更
openspec/specs/worker-artifact-pipeline/spec.md：併入 lineage graph API、stable artifact IDs、all-IFC-entity coverage denominator、minimum_coverage_ratio=1.0policy 與 storage batch verification requirements。openspec/specs/runtime-verification-evidence/spec.md：併入 storage batch evidence tier、locked mapping baseline evidence、issue-to-real-prim evidence 條件。openspec/specs/worker-demo-upload-convert-ui/spec.md：併入 worker UI lineage / quality view requirements。openspec/changes/archive/2026-05-12-worker-mapping-lineage-quality-baseline/：保留已接受 change 的 proposal、design、tasks 與 delta spec 快照。docs/plans/AI-BIM-governance-saas-roadmap-2026-05.md與.html：同步 archive 狀態、候選清單、Phase 1 gap、優先順序與下一步。驗證方式
openspec archive worker-mapping-lineage-quality-baseline --yes：完成，更新 3 個 specs，archive folder 已建立。openspec validate --all --strict：11 specs passed, 0 failed。git diff --check：通過。gitnexus detect-changes --scope compare --base-ref origin/main --repo AI-BIM-governance：回報 HIGH，但內容指向已合併 PR feat(worker): 建立 lineage API 與 IFC entity coverage 基線 #29 的_workersymbols；fallbackgit diff --name-only origin/main確認本 PR scope 僅 OpenSpec specs/archive 與 roadmap 文件。風險與影響
runtime-verification-evidence現在明確要求 canonical storage batch evidence 才能宣稱 production mapping baseline locked。#4 coordinator-session-lifecycle-events-audit為主。回滾方式
Revert 此 PR 的 merge commit，可將
openspec/specs/與 roadmap 回到 archive 前狀態，並把 change artifacts 從 archive path 還原到 active change path。後續建議
C:\Repos\active\iot\AI-BIM-governance\storage\*.ifccanonical 13-file real batch evidence。--limit 1超過 600s timeout 的 runtime / performance blocker，再宣稱 production baseline locked。Summary by CodeRabbit