Repository navigation
feat(coordinator): auto-ingest 把 quality_metrics_summary forward 進 stream-config - #115
Merged
monkey1sai merged 1 commit intoMay 26, 2026
Conversation
…ream-config (coordinator-forward-quality-metrics-summary) C1 / C2 / C3 archive 後 fast MVP closed loop 的最後一段:coordinator 自動 ingest streaming conversion 結果建立 review session 時,從 result 萃取 quality_metrics 寫進 session,viewer / /ui 後續從 stream-config 拿到後 三段 ready 的 Semantic 才能真正算 yes(C1 fallback 已產資料、C2 viewer 已正確讀,但 coordinator 中段沒 forward → 永遠 null → Semantic=no)。 變更: - types.ts ConversionQualityMetricsSummary 加 C1 三欄位 (semantic_mapping_fidelity / mapping_has_ifc_type / mapping_has_ifc_name), 全 optional/nullable,backward compatible - app.ts qualityMetricsSummarySchema zod 加同三欄位 - streamingConversionClient.ts 新增 buildQualityMetricsSummary helper 從 result.raw.quality_metrics 萃取所有欄位,best-effort 對齊 dev-console.html 既有 mapping 風格 - ingestStreamingConversionResult / ingestConversionReport / autoCreateOrActivateSession 加 qualitySummary arg,寫進 store.create 新增 3 個 vitest: - semantic 三欄位 + 既有欄位 + phase_timings 全 forward - 部分 quality_metrics → 缺欄位顯式 null(schema stable) - 無 quality_metrics → summary=null(backward compat) 不改 streaming-server / viewer / callback outbox 邊界;不引入 new dep。 OpenSpec change:coordinator-forward-quality-metrics-summary
Contributor
|
Warning Review limit reached
More reviews will be available in 48 minutes and 52 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
monkey1sai
deleted the
codex/openspec/coordinator-forward-quality-metrics-summary
branch
May 26, 2026 02:23
monkey1sai
added a commit
that referenced
this pull request
May 26, 2026
… chrome evidence (#116) PR #115 已 merged,完成 OpenSpec sync/archive: - openspec/changes/archive/2026-05-26-coordinator-forward-quality-metrics-summary/ - openspec/specs/conversion-webhook-lifecycle/spec.md(+1 requirement ADD) - openspec/specs/ 仍 26 capability,openspec validate --specs --strict 26/0 Chrome MCP archive-closeout evidence(docs/evidence/.../c2-viewer-semantic-yes-after-forward.md): forward 機制 100% 驗證: - coordinator stream-config response.quality_metrics_summary 帶 source_ifc_entity_count=10872、 materialization_strategy=usd_stage_enumeration、coverage_status=warn 等(過去全 null) - 三個 C1 semantic 欄位明示 null,schema stable - viewer triReady: File=yes / Runtime=yes / Semantic=no(預期) - TopBar 全綠;stage-truth-panel--matched 剩餘 gap 暴露:conversion 走 usd_stage_enumeration path(HOOPS 處理 89MB IFC 成功), 非 C1 fallback;該 path 沒寫 semantic_mapping_fidelity / mapping_has_ifc_type / mapping_has_ifc_name。建議下一個 OpenSpec change: streaming-server-enumeration-semantic-mapping 接力。
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates bim-review-coordinator’s auto-ingest flow so that streaming conversion quality_metrics are extracted into quality_metrics_summary and forwarded through GET /api/review-sessions/:id/stream-config, enabling viewer and /ui to compute Semantic readiness using the C1 fallback fields.
Changes:
- Extend
ConversionQualityMetricsSummary(+ zod schema) with the three C1 semantic fields (semantic_mapping_fidelity,mapping_has_ifc_type,mapping_has_ifc_name). - Add
buildQualityMetricsSummary()to extract a best-effort summary from streaming conversion results and plumb it through ingest → session creation. - Add vitest coverage for auto-ingest forwarding behavior (full/partial/no
quality_metrics).
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| openspec/changes/coordinator-forward-quality-metrics-summary/tasks.md | Adds the change task checklist for this OpenSpec change. |
| openspec/changes/coordinator-forward-quality-metrics-summary/specs/conversion-webhook-lifecycle/spec.md | Spec delta requiring coordinator to forward streaming quality_metrics into quality_metrics_summary for stream-config consumers. |
| openspec/changes/coordinator-forward-quality-metrics-summary/proposal.md | Motivation and scope/compat notes for forwarding semantic readiness metrics. |
| openspec/changes/coordinator-forward-quality-metrics-summary/design.md | Design for additive type/schema extension and best-effort extraction helper. |
| bim-review-coordinator/tests/host-native-conversion-ingest.test.ts | Adds tests asserting ingest forwards quality_metrics_summary into stream-config (including null-vs-undefined expectations). |
| bim-review-coordinator/src/types.ts | Extends ConversionQualityMetricsSummary with three new C1 semantic fields (additive). |
| bim-review-coordinator/src/services/streamingConversionClient.ts | Introduces buildQualityMetricsSummary() helper to extract a summary from result.raw.quality_metrics. |
| bim-review-coordinator/src/app.ts | Wires the extracted quality summary through ingest and into auto-created sessions’ quality_metrics_summary. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+350
to
+353
| const fixtureName = | ||
| typeof raw.original_filename === "string" ? (raw.original_filename as string) : null; | ||
| const artifactGroupId = | ||
| typeof raw.artifact_group_id === "string" ? (raw.artifact_group_id as string) : null; |
Comment on lines
+10
to
+37
| ## 1. Failing tests first | ||
|
|
||
| - [ ] 1.1 新增 `tests/quality-metrics-summary-forward.test.ts`(vitest): | ||
| Scenario A(C1 三欄位 + 既有欄位 → stream-config 帶全)、Scenario B | ||
| (phase_timings.conversion_total.duration_seconds → conversion_duration_seconds)、 | ||
| Scenario C(無 quality_metrics → summary=null,viewer Semantic 仍 no)。 | ||
| - [ ] 1.2 跑 `npm test` → 三個新 test FAIL。 | ||
|
|
||
| ## 2. Implementation | ||
|
|
||
| - [ ] 2.1 修改 `src/types.ts`:`ConversionQualityMetricsSummary` 加 | ||
| `semantic_mapping_fidelity?` / `mapping_has_ifc_type?` / `mapping_has_ifc_name?`。 | ||
| - [ ] 2.2 修改 `src/app.ts:88-94` `qualityMetricsSummarySchema` zod schema 加同欄位。 | ||
| - [ ] 2.3 `src/services/streamingConversionClient.ts` 新增 | ||
| `buildQualityMetricsSummary(result): ConversionQualityMetricsSummary | null`。 | ||
| - [ ] 2.4 修改 `src/app.ts` `createReviewSessionFromIngest`:把 | ||
| `quality_metrics_summary: null` 改成 | ||
| `quality_metrics_summary: buildQualityMetricsSummary(result)`。 | ||
| - [ ] 2.5 `npm run build` 通過。 | ||
|
|
||
| ## 3. Verify | ||
|
|
||
| - [ ] 3.1 `npm test` 全綠(三新 + 既有)。 | ||
| - [ ] 3.2 `npm run build` 通過。 | ||
| - [ ] 3.3 `npm run verify` 通過。 | ||
| - [ ] 3.4 `openspec validate coordinator-forward-quality-metrics-summary --strict`。 | ||
| - [ ] 3.5 `openspec validate --specs --strict`。 | ||
|
|
This was referenced May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C1 / C2 / C3 archive 後 fast MVP closed loop 的最後一段。coordinator 自動 ingest streaming conversion 結果建立 review session 時,從 result 萃取 quality_metrics 寫進 session,viewer /
/ui後續從 stream-config 拿到後三段 ready 的 Semantic 才能真正算 yes。Why
semantic_mapping_fidelity/mapping_has_ifc_type/mapping_has_ifc_namecomputeSemanticReady嚴格依這三欄位/ui同欄位來源createReviewSessionFromIngest(app.ts:833)直接設quality_metrics_summary: null→ viewer //ui永遠Semantic: noChanges
types.tsConversionQualityMetricsSummary加 C1 三欄位(optional + nullable,strictly additive)app.tsqualityMetricsSummarySchemazod 加同三欄位streamingConversionClient.ts新增buildQualityMetricsSummaryhelper(萃取result.raw.quality_metrics全欄位 +phase_timings.conversion_total.duration_seconds)ingestStreamingConversionResult/ingestConversionReport/autoCreateOrActivateSession加qualitySummaryarg,寫進store.createScope guard
quality_metrics時 summary=null,viewer 對 null 仍按 C2 規則計算 Semantic=noPOST /api/review-sessionscaller path 不變(qualitySummary arg 有 default null)Test plan
npm test→ 13 test files / 187 tests passed(原 184 + 3 新)npm run build通過npm run verify通過openspec validate coordinator-forward-quality-metrics-summary --strict→ validopenspec validate --specs --strict→ 26 passedgit diff --cached --checkcleanArchive gate(post-merge)
Re-run Chrome MCP viewer evidence 對 ready session 應觀察:
Semantic: no→Semantic: yes(若 C1 fallback 三欄位都 truthy)docs/evidence/2026-05-25-fast-mvp-edge-bim-server-console/c2-viewer-semantic-yes-after-forward.md🤖 Generated with Claude Code