Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KeyDecoder/KeyEncoder to Circe integrations #179

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

satorg
Copy link

@satorg satorg commented Oct 13, 2024

Introduces DerivedCirceKeyCodec along with DerivedCirceKeyDecoder and DerivedCirceKeyEncoder to provide support for keys in Circe.

Seems to be a pretty straightforward addition. The code mostly follows the pattern in DerivedCirceCodec and its counterparts.

@satorg
Copy link
Author

satorg commented Oct 13, 2024

I've just realized that I missed this suggestion from "CONTRIBUTING.md"

  1. Before starting to work, make sure there is a ticket in the issue or create one first. It can help accelerate the acceptance process if the change is agreed upon

I can file it if it is still required. Sorry for my negligence.

Also it doesn't seem there's any "AUTHORS" file to meet this one:

  1. Your first commit request should be accompanied with a change to the AUTHORS file, adding yourself to the authors list.

@alexandru
Copy link
Member

Thanks for the PR, and sorry for the latency, I'm looking at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants