Skip to content

DRIVERS-2295 fix typos and add missing $$unsetOrMatches #1836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 8, 2025
Merged

DRIVERS-2295 fix typos and add missing $$unsetOrMatches #1836

merged 2 commits into from
Sep 8, 2025
+22 −6

Conversation

@kevinAlbs
Copy link
Contributor

@kevinAlbs kevinAlbs commented Sep 8, 2025 •
edited
Loading

Follow-up to #1784:

  • Replace collMod with createIndexes so commandName and command match.
  • Add missing $$unsetOrMatches to update expectations.
  • Fix typo in CSOT tests: expectResult => expectError.

Please complete the following before merging:

  • Update changelog.
  • Test changes in at least one language driver. (Tested locally in C driver)
  • Test these changes against all server versions and topologies (including standalone, replica set, and sharded
    clusters).

@kevinAlbs
DRIVERS-2295 fix typo in commandName
e169bea 
Replace `collMod` with `createIndexes` so `commandName` and `command` match.
blink1073
blink1073 approved these changes Sep 8, 2025
View reviewed changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@blink1073
Copy link
Member

I've tested all of these changes with the Python driver

@kevinAlbs kevinAlbs changed the title DRIVERS-2295 fix typo in commandName DRIVERS-2295 fix typos and add missing $$unsetOrMatches Sep 8, 2025
kevinAlbs
kevinAlbs commented Sep 8, 2025
View reviewed changes
Copy link
Contributor Author

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the added fixes. Tested updateOne.json in the C driver, but not timeoutMS.json (since C does not-yet implement CSOT).

@kevinAlbs kevinAlbs marked this pull request as ready for review September 8, 2025 14:02
@kevinAlbs kevinAlbs requested a review from a team as a code owner September 8, 2025 14:02
@kevinAlbs kevinAlbs requested review from katcharov and removed request for a team and katcharov September 8, 2025 14:02
@kevinAlbs kevinAlbs merged commit eb7f9a2 into mongodb:master Sep 8, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kevinAlbs @blink1073