-
Notifications
You must be signed in to change notification settings - Fork 246
DRIVERS-2789 Clean up source file structure #1663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| # BSON Binary Subtype 6 | ||
| # BSON Binary Encrypted | ||
|
|
||
| - Status: Accepted | ||
| - Minimum Server Version: 4.2 | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| # Handling of Native UUID Types | ||
| # BSON Binary UUID | ||
|
|
||
| - Status: Accepted | ||
| - Minimum Server Version: N/A | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| # Handling of DBRefs | ||
| # BSON DBRef | ||
|
|
||
| - Status: Accepted | ||
| - Minimum Server Version: N/A | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| # BSON Decimal128 Type Handling in Drivers | ||
| # BSON Decimal128 | ||
|
|
||
| - Status: Accepted | ||
| - Minimum Server Version: 3.4 | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| # ObjectID format | ||
| # BSON ObjectID | ||
|
|
||
| - Status: Accepted | ||
| - Minimum Server Version: N/A | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
|
|
||
| .. note:: | ||
| This specification has been converted to Markdown and renamed to | ||
| `subtype6.md <subtype6.md>`_. | ||
| `subtype6.md <../bson-binary-encrypted/binary-encrypted.md>`_. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
|
|
||
| .. note:: | ||
| This specification has been converted to Markdown and renamed to | ||
| `dbref.md <dbref.md>`_. | ||
| `dbref.md <bson-dbref/dbref.md>`_. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
|
|
||
| .. note:: | ||
| This specification has been converted to Markdown and renamed to | ||
| `enumerate-collections.md <enumerate-collections.md>`_. | ||
| `enumerate-collections.md <enumerate-collections/enumerate-collections.md>`_. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
|
|
||
| .. note:: | ||
| This specification has been converted to Markdown and renamed to | ||
| `enumerate-databases.md <enumerate-databases.md>`_. | ||
| `enumerate-databases.md <enumerate-databases/enumerate-databases.md>`_. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
|
|
||
| .. note:: | ||
| This specification has been converted to Markdown and renamed to | ||
| `extended-json.md <extended-json.md>`_. | ||
| `extended-json.md <extended-json/extended-json.md>`_. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
|
|
||
| .. note:: | ||
| This specification has been converted to Markdown and renamed to | ||
| `find_getmore_killcursors_commands.md <find_getmore_killcursors_commands.md>`_. | ||
| `find_getmore_killcursors_commands.md <find_getmore_killcursors_commands/find_getmore_killcursors_commands.md>`_. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,9 +2,12 @@ | |
|
|
||
| - [Atlas Serverless Tests](serverless-testing/README.md) | ||
| - [Authentication](auth/auth.md) | ||
| - [BSON Binary Subtype 6](client-side-encryption/subtype6.md) | ||
| - [BSON Binary Encrypted](bson-binary-encrypted/binary-encrypted.md) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similar to how we have multiple documents in the SDAM spec folder, how about moving all of the various BSON specs into a bson folder with an index document that links to the main BSON spec (https://bsonspec.org) and our own specifications?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd want to leave BSON-corpus out of that move, at least in this PR, since drivers are keying in on paths to sync spec files. For #1658, we'd move the spec file into this new
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Works for me 👍
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Haha, I meant that as a question. Should I make a
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh, sorry. Yes, having a There could also be a single
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The tests are different from the standard corpus tests, because there is additional metadata in the BSON binary value. So I think we should keep these folders separate. |
||
| - [BSON Binary UUID](bson-binary-uuid/uuid.md) | ||
| - [BSON Corpus](bson-corpus/bson-corpus.md) | ||
| - [BSON Decimal128 Type Handling in Drivers](bson-decimal128/decimal128.md) | ||
| - [BSON DBRef](bson-dbref/dbref.md) | ||
| - [BSON Decimal128](bson-decimal128/decimal128.md) | ||
| - [BSON ObjectID](bson-objectid/objectid.md) | ||
| - [Bulk Write](crud/bulk-write.md) | ||
| - [CRUD API](crud/crud.md) | ||
| - [Causal Consistency Specification](causal-consistency/causal-consistency.md) | ||
|
|
@@ -17,14 +20,12 @@ | |
| - [Connection String Spec](connection-string/connection-string-spec.md) | ||
| - [Convenient API for Transactions](transactions-convenient-api/transactions-convenient-api.md) | ||
| - [Driver Mantras](./driver-mantras.md) | ||
| - [Enumerating Collections](./enumerate-collections.md) | ||
| - [Enumerating Databases](./enumerate-databases.md) | ||
| - [Extended JSON](./extended-json.md) | ||
| - [Enumerating Collections](enumerate-collections/enumerate-collections.md) | ||
| - [Enumerating Databases](enumerate-databases/enumerate-databases.md) | ||
| - [Extended JSON](extended-json/extended-json.md) | ||
| - [FaaS Automated Testing](faas-automated-testing/faas-automated-testing.md) | ||
| - [Find, getMore and killCursors commands.](./find_getmore_killcursors_commands.md) | ||
| - [Find, getMore and killCursors commands](find_getmore_killcursors_commands/find_getmore_killcursors_commands.md) | ||
| - [GridFS Spec](gridfs/gridfs-spec.md) | ||
| - [Handling of DBRefs](./dbref.md) | ||
| - [Handling of Native UUID Types](./uuid.md) | ||
| - [Index Management](index-management/index-management.md) | ||
| - [Initial DNS Seedlist Discovery](initial-dns-seedlist-discovery/initial-dns-seedlist-discovery.md) | ||
| - [Load Balancer Support](load-balancers/load-balancers.md) | ||
|
|
@@ -34,7 +35,6 @@ | |
| - [MongoDB Handshake](mongodb-handshake/handshake.md) | ||
| - [OCSP Support](ocsp-support/ocsp-support.md) | ||
| - [OP_MSG](message/OP_MSG.md) | ||
| - [ObjectID format](./objectid.md) | ||
| - [Performance Benchmarking](benchmarking/benchmarking.md) | ||
| - [Polling SRV Records for mongos Discovery](polling-srv-records-for-mongos-discovery/polling-srv-records-for-mongos-discovery.md) | ||
| - [Read and Write Concern](read-write-concern/read-write-concern.md) | ||
|
|
@@ -49,12 +49,12 @@ | |
| - [Server Monitoring](server-discovery-and-monitoring/server-monitoring.md) | ||
| - [Server Selection](server-selection/server-selection.md) | ||
| - [Server Selection Test Plan](server-selection/server-selection-tests.md) | ||
| - [Server Wire version and Feature List](./wireversion-featurelist.md) | ||
| - [Server Wire version and Feature List](wireversion-featurelist/wireversion-featurelist.md) | ||
| - [Sessions Specification](sessions/driver-sessions.md) | ||
| - [Snapshot Reads Specification](sessions/snapshot-sessions.md) | ||
| - [Stable API For Drivers](versioned-api/versioned-api.md) | ||
| - [Transactions Specification](transactions/transactions.md) | ||
| - [URI Options Specification](uri-options/uri-options.md) | ||
| - [Unified Test Format](unified-test-format/unified-test-format.md) | ||
| - [Wire Compression in Drivers](compression/OP_COMPRESSED.md) | ||
| - [Write Commands Specification](./server_write_commands.md) | ||
| - [Write Commands Specification](server_write_commands/server_write_commands.md) | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
|
|
||
| .. note:: | ||
| This specification has been converted to Markdown and renamed to | ||
| `objectid.md <objectid.md>`_. | ||
| `objectid.md <bson-objectid/objectid.md>`_. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
|
|
||
| .. note:: | ||
| This specification has been converted to Markdown and renamed to | ||
| `server_write_commands.md <server_write_commands.md>`_. | ||
| `server_write_commands.md <server_write_commands/server_write_commands.md>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Looking at other "BSON <type>" specs, this suggests that
DBRefis a BSON type, which it isn't. Any objections to just calling this the "DBRef spec"?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, right, I was confusing it with the deprecated
DBPointer.