Skip to content

Conversation

@durran
Copy link
Member

@durran durran commented Jan 17, 2023

Adds a unified test in command monitoring tests that ensures a command succeeded event is emitted when a reply contains write concern errors and { ok: 1 }. The additional test runs against replica sets, so the first client failure forces a retry of the write so the expected events are command started, command succeeded, command started, command succeeded.

Node implementation passing here: mongodb/node-mongodb-native#3525

Please complete the following before merging:

  • Update changelog.
  • Make sure there are generated JSON files from the YAML test files.
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded clusters, and serverless).

@durran durran requested a review from a team as a code owner January 17, 2023 13:26
@durran durran requested review from jyemin and removed request for a team January 17, 2023 13:26
@jyemin jyemin requested a review from kmahar January 17, 2023 13:44
Copy link
Contributor

@kmahar kmahar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the test looks ok from a quick inspection. let me see tomorrow if I can quickly fix the bug in Rust and see if the test passes there too. I'd like to add an equivalent command logging test

@durran durran requested a review from kmahar January 18, 2023 19:10
@durran durran merged commit 18932c0 into master Jan 19, 2023
@durran durran deleted the DRIVERS-2468 branch January 19, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants