-
Notifications
You must be signed in to change notification settings - Fork 247
DRIVERS-2344: add disambiguatedPaths to change streams update document #1292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
72dc6ea
add disambiguatedPaths to change streams update document
baileympearson 4c9b173
chore: update changelog and bump spec version
baileympearson fcca0f8
chore: remove unintentional change
baileympearson 2cd8cff
chore: remove unintentional change
baileympearson 3023642
Address Benji's comment
baileympearson f898171
chore: bump updated at date
durran File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
251 changes: 251 additions & 0 deletions
251
source/change-streams/tests/unified/change-streams-disambiguatedPaths.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,251 @@ | ||
| { | ||
| "description": "disambiguatedPaths", | ||
| "schemaVersion": "1.3", | ||
| "createEntities": [ | ||
| { | ||
| "client": { | ||
| "id": "client0", | ||
| "useMultipleMongoses": false | ||
| } | ||
| }, | ||
| { | ||
| "database": { | ||
| "id": "database0", | ||
| "client": "client0", | ||
| "databaseName": "database0" | ||
| } | ||
| }, | ||
| { | ||
| "collection": { | ||
| "id": "collection0", | ||
| "database": "database0", | ||
| "collectionName": "collection0" | ||
| } | ||
| } | ||
| ], | ||
| "runOnRequirements": [ | ||
| { | ||
| "minServerVersion": "6.1.0", | ||
| "topologies": [ | ||
| "replicaset", | ||
| "sharded-replicaset", | ||
| "load-balanced", | ||
| "sharded" | ||
| ] | ||
| } | ||
| ], | ||
| "initialData": [ | ||
| { | ||
| "collectionName": "collection0", | ||
| "databaseName": "database0", | ||
| "documents": [] | ||
| } | ||
| ], | ||
| "tests": [ | ||
| { | ||
| "description": "disambiguatedPaths is not present when showExpandedEvents is false/unset", | ||
| "operations": [ | ||
| { | ||
| "name": "insertOne", | ||
| "object": "collection0", | ||
| "arguments": { | ||
| "document": { | ||
| "_id": 1, | ||
| "a": { | ||
| "1": 1 | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "name": "createChangeStream", | ||
| "object": "collection0", | ||
| "arguments": { | ||
| "pipeline": [] | ||
| }, | ||
| "saveResultAsEntity": "changeStream0" | ||
| }, | ||
| { | ||
| "name": "updateOne", | ||
| "object": "collection0", | ||
| "arguments": { | ||
| "filter": { | ||
| "_id": 1 | ||
| }, | ||
| "update": { | ||
| "$set": { | ||
| "a.1": 2 | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "name": "iterateUntilDocumentOrError", | ||
| "object": "changeStream0", | ||
| "expectResult": { | ||
| "operationType": "update", | ||
| "ns": { | ||
| "db": "database0", | ||
| "coll": "collection0" | ||
| }, | ||
| "updateDescription": { | ||
| "updatedFields": { | ||
| "$$exists": true | ||
| }, | ||
| "removedFields": { | ||
| "$$exists": true | ||
| }, | ||
| "truncatedArrays": { | ||
| "$$exists": true | ||
| }, | ||
| "disambiguatedPaths": { | ||
| "$$exists": false | ||
| } | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "description": "disambiguatedPaths is present on updateDescription when an ambiguous path is present", | ||
| "operations": [ | ||
| { | ||
| "name": "insertOne", | ||
| "object": "collection0", | ||
| "arguments": { | ||
| "document": { | ||
| "_id": 1, | ||
| "a": { | ||
| "1": 1 | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "name": "createChangeStream", | ||
| "object": "collection0", | ||
| "arguments": { | ||
| "pipeline": [], | ||
| "showExpandedEvents": true | ||
| }, | ||
| "saveResultAsEntity": "changeStream0" | ||
| }, | ||
| { | ||
| "name": "updateOne", | ||
| "object": "collection0", | ||
| "arguments": { | ||
| "filter": { | ||
| "_id": 1 | ||
| }, | ||
| "update": { | ||
| "$set": { | ||
| "a.1": 2 | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "name": "iterateUntilDocumentOrError", | ||
| "object": "changeStream0", | ||
| "expectResult": { | ||
| "operationType": "update", | ||
| "ns": { | ||
| "db": "database0", | ||
| "coll": "collection0" | ||
| }, | ||
| "updateDescription": { | ||
| "updatedFields": { | ||
| "$$exists": true | ||
| }, | ||
| "removedFields": { | ||
| "$$exists": true | ||
| }, | ||
| "truncatedArrays": { | ||
| "$$exists": true | ||
| }, | ||
| "disambiguatedPaths": { | ||
| "a.1": [ | ||
| "a", | ||
| "1" | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "description": "disambiguatedPaths returns array indices as integers", | ||
| "operations": [ | ||
| { | ||
| "name": "insertOne", | ||
| "object": "collection0", | ||
| "arguments": { | ||
| "document": { | ||
| "_id": 1, | ||
| "a": [ | ||
| { | ||
| "1": 1 | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "name": "createChangeStream", | ||
| "object": "collection0", | ||
| "arguments": { | ||
| "pipeline": [], | ||
| "showExpandedEvents": true | ||
| }, | ||
| "saveResultAsEntity": "changeStream0" | ||
| }, | ||
| { | ||
| "name": "updateOne", | ||
| "object": "collection0", | ||
| "arguments": { | ||
| "filter": { | ||
| "_id": 1 | ||
| }, | ||
| "update": { | ||
| "$set": { | ||
| "a.0.1": 2 | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "name": "iterateUntilDocumentOrError", | ||
| "object": "changeStream0", | ||
| "expectResult": { | ||
| "operationType": "update", | ||
| "ns": { | ||
| "db": "database0", | ||
| "coll": "collection0" | ||
| }, | ||
| "updateDescription": { | ||
| "updatedFields": { | ||
| "$$exists": true | ||
| }, | ||
| "removedFields": { | ||
| "$$exists": true | ||
| }, | ||
| "truncatedArrays": { | ||
| "$$exists": true | ||
| }, | ||
| "disambiguatedPaths": { | ||
| "a.0.1": [ | ||
| "a", | ||
| { | ||
| "$$type": "int" | ||
| }, | ||
| "1" | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } |
102 changes: 102 additions & 0 deletions
102
source/change-streams/tests/unified/change-streams-disambiguatedPaths.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,102 @@ | ||
| description: "disambiguatedPaths" | ||
| schemaVersion: "1.3" | ||
| createEntities: | ||
| - client: | ||
| id: &client0 client0 | ||
| useMultipleMongoses: false | ||
| - database: | ||
| id: &database0 database0 | ||
| client: *client0 | ||
| databaseName: *database0 | ||
| - collection: | ||
| id: &collection0 collection0 | ||
| database: *database0 | ||
| collectionName: *collection0 | ||
|
|
||
| runOnRequirements: | ||
| - minServerVersion: "6.1.0" | ||
| topologies: [ replicaset, sharded-replicaset, load-balanced, sharded ] | ||
|
|
||
| initialData: | ||
| - collectionName: *collection0 | ||
| databaseName: *database0 | ||
| documents: [] | ||
|
|
||
| tests: | ||
| - description: "disambiguatedPaths is not present when showExpandedEvents is false/unset" | ||
| operations: | ||
| - name: insertOne | ||
| object: *collection0 | ||
| arguments: | ||
| document: { _id: 1, 'a': { '1': 1 } } | ||
| - name: createChangeStream | ||
| object: *collection0 | ||
| arguments: { pipeline: [] } | ||
| saveResultAsEntity: &changeStream0 changeStream0 | ||
| - name: updateOne | ||
| object: *collection0 | ||
| arguments: | ||
| filter: { _id: 1 } | ||
| update: { $set: { 'a.1': 2 } } | ||
| - name: iterateUntilDocumentOrError | ||
| object: *changeStream0 | ||
| expectResult: | ||
| operationType: "update" | ||
| ns: { db: *database0, coll: *collection0 } | ||
| updateDescription: | ||
| updatedFields: { $$exists: true } | ||
| removedFields: { $$exists: true } | ||
| truncatedArrays: { $$exists: true } | ||
| disambiguatedPaths: { $$exists: false } | ||
|
|
||
| - description: "disambiguatedPaths is present on updateDescription when an ambiguous path is present" | ||
| operations: | ||
| - name: insertOne | ||
| object: *collection0 | ||
| arguments: | ||
| document: { _id: 1, 'a': { '1': 1 } } | ||
| - name: createChangeStream | ||
| object: *collection0 | ||
| arguments: { pipeline: [], showExpandedEvents: true } | ||
| saveResultAsEntity: &changeStream0 changeStream0 | ||
| - name: updateOne | ||
| object: *collection0 | ||
| arguments: | ||
| filter: { _id: 1 } | ||
| update: { $set: { 'a.1': 2 } } | ||
| - name: iterateUntilDocumentOrError | ||
| object: *changeStream0 | ||
| expectResult: | ||
| operationType: "update" | ||
| ns: { db: *database0, coll: *collection0 } | ||
| updateDescription: | ||
| updatedFields: { $$exists: true } | ||
| removedFields: { $$exists: true } | ||
| truncatedArrays: { $$exists: true } | ||
| disambiguatedPaths: { 'a.1': ['a', '1'] } | ||
|
|
||
| - description: "disambiguatedPaths returns array indices as integers" | ||
| operations: | ||
| - name: insertOne | ||
| object: *collection0 | ||
| arguments: | ||
| document: { _id: 1, 'a': [{'1': 1 }] } | ||
| - name: createChangeStream | ||
| object: *collection0 | ||
| arguments: { pipeline: [], showExpandedEvents: true } | ||
| saveResultAsEntity: &changeStream0 changeStream0 | ||
| - name: updateOne | ||
| object: *collection0 | ||
| arguments: | ||
| filter: { _id: 1 } | ||
| update: { $set: { 'a.0.1': 2 } } | ||
| - name: iterateUntilDocumentOrError | ||
| object: *changeStream0 | ||
| expectResult: | ||
| operationType: "update" | ||
| ns: { db: *database0, coll: *collection0 } | ||
| updateDescription: | ||
| updatedFields: { $$exists: true } | ||
| removedFields: { $$exists: true } | ||
| truncatedArrays: { $$exists: true } | ||
| disambiguatedPaths: { 'a.0.1': ['a', { $$type: 'int' }, '1'] } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[opt] You could use
"to be consistent with the other spec tests.