Skip to content

fix(DRIVERS-1975): add commandName to runCommand usage in tests #1247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
baileympearson merged 2 commits into from
Jun 14, 2022
Merged

fix(DRIVERS-1975): add commandName to runCommand usage in tests #1247

baileympearson merged 2 commits into from
Jun 14, 2022

Conversation

@baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Jun 13, 2022

Tests are updated in passing in Node - mongodb/node-mongodb-native#3288

Please complete the following before merging:

  • Bump spec version and last modified date.
  • Update changelog.
  • Make sure there are generated JSON files from the YAML test files.
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded clusters, and serverless).

@baileympearson baileympearson requested a review from a team as a code owner June 13, 2022 17:16
@baileympearson baileympearson requested review from benjirewis and removed request for a team June 13, 2022 17:16
benjirewis
benjirewis approved these changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@benjirewis benjirewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@baileympearson baileympearson merged commit 8da1a89 into mongodb:master Jun 14, 2022
@baileympearson baileympearson deleted the DRIVERS-1975-add-commandName-to-runCommand branch June 14, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@benjirewis benjirewis benjirewis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@baileympearson @benjirewis