fix(NODE-5945): make AWS session token optional #4006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
changed the title
nbbeeken
added
the
Primary Review
nbbeeken
requested changes
Mar 1, 2024
nbbeeken
approved these changes
Mar 4, 2024
alenakhineika
added
Team Review
aditi-khare-mongoDB
pushed a commit
that referenced
this pull request
Mar 7, 2024
Co-authored-by: Neal Beeken <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport optional AWS session token fix.
What is changing?
Do not throw the
MongoMissingCredentialsError('Could not obtain temporary MONGODB-AWS credentials')exception when the AWS token is missing.Is there new documentation needed for these changes?
None
What is the motivation for this change?
NODE-5945
Release Highlight
The AWS token is now optional
Users may provide an
AWS_SESSION_TOKENas a client option or AWS configuration in addition to a username and password. But if the token is not provided, the driver won't throw an exception and let AWS SDK handle the request.Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript