fix(NODE-4254): allow csfle to be dynamically required #3260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
approved these changes
May 23, 2022
baileympearson
requested changes
May 23, 2022
Contributor
baileympearson
left a comment
baileympearson
left a comment
There was a problem hiding this comment.
approved the PR - requesting changes to undo the approval
bajanam
added
the
Primary Review
addaleax
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows setting mongodb-client-encryption to an env variable to locate it on the local filesystem.
Needs mongodb/libmongocrypt#342 to work.
Update: changed csfle tests to run on replica sets here (NODE-4236) in order to get the now running tests to pass.
What is changing?
If
MONGODB_CLIENT_ENCRYPTION_OVERRIDEis present, will attempt to require csfle from that location.Is there new documentation needed for these changes?
No
What is the motivation for this change?
NODE-4254
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>