fix(NODE-3928): don't throw error in Response constructor #3199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durran
force-pushed
the
NODE-3928
branch
4 times, most recently
from
43cc3aa to
7512a77
Compare
baileympearson
requested changes
Apr 13, 2022
baileympearson
previously approved these changes
Apr 15, 2022
Contributor
baileympearson
left a comment
baileympearson
left a comment
There was a problem hiding this comment.
Thanks for adding the tests. Looks good!
nbbeeken
suggested changes
Apr 15, 2022
baileympearson
approved these changes
Apr 20, 2022
baileympearson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Don't raise an error in the
Responseconstructor.What is changing?
Moves all logic that reads from the message body into the
parsemethod to allow for any raised exception to be properly handled in a callback.Is there new documentation needed for these changes?
No.
What is the motivation for this change?
NODE-3928
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>