feat(NODE-3784): Add enableUtf8Validation option
#3074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DE-3784/Add-utf8-validation-option
- tests are not passing, pushing to github to get feedback - Validation options are not propagating to the binmsg layer for any configuration
…DE-3784/Add-utf8-validation-option
…DE-3784/Add-utf8-validation-option
- remove todo statement - change test description - rename test file to match code file name
…DE-3784/Add-utf8-validation-option
dariakp
requested changes
Dec 9, 2021
Contributor
dariakp
left a comment
dariakp
left a comment
There was a problem hiding this comment.
No changes required, but wait to merge until patch release
dariakp
added
Blocked
dariakp
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
A new option was added to the db, client, operation and collection classes to allow users to enable/disable utf8 validation.
The legacy response class is not modified - deserialization changes are only present in the
BinMsgclass.Is there new documentation needed for these changes?
Yes
What is the motivation for this change?
UTF8 validation is now enabled by default. Disabling utf8 validation can result in a performance benefit for users.
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>