fix: versioned api low node compat fix #2970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariakp
force-pushed
the
chore-3.7-evergreen-low-node-compat-fix
branch
from
8c5df03
to
b6498e9
Compare
nbbeeken
approved these changes
Aug 31, 2021
emadum
approved these changes
Aug 31, 2021
| @@ -3,12 +3,13 @@ | |||
| const expect = require('chai').expect; | |||
| const loadSpecTests = require('../spec/index').loadSpecTests; | |||
| const runUnifiedTest = require('./unified-spec-runner/runner').runUnifiedTest; | |||
| const ServerApiVersion = require('../../lib/core').ServerApiVersion; | |||
| const ValidServerApiVersions = require('../../lib/core').ValidServerApiVersions; | |||
There was a problem hiding this comment.
Suggested change
| const ValidServerApiVersions = require('../../lib/core').ValidServerApiVersions; | |
| const validVersions = require('../../lib/core').ValidServerApiVersions; |
Nit, but if you rename this here there's no need for the second declaration further down.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating versioned API not to use
Object.valuesand unified runner not to use the node util for deep equality check.