fix: Compatibility with mongodb-client-encryption #2713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Permits legacy options being used by mongodb-client-encryption's use of the MongoClient constructor. Permits legacy WC option style in insertOne. NODE-3006
nbbeeken
commented
Jan 22, 2021
Contributor
Author
nbbeeken
left a comment
nbbeeken
left a comment
There was a problem hiding this comment.
Instead of making a change to 'mongodb-client-encryption` and managing version compatibility I think we should just support the small patches needed to make the existing package work.
Comment on lines
+286
to
+290
| // CSFLE passes in { w: 'majority' } to ensure the lib works in both 3.x and 4.x | ||
| // we support that option style here only | ||
| if (options && Reflect.get(options, 'w')) { | ||
| options.writeConcern = WriteConcern.fromOptions(Reflect.get(options, 'w')); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Here that is just checking for the legacy writeConcern shape
Comment on lines
+1067
to
+1068
| useNewUrlParser: { type: 'boolean' } as OptionDescriptor, | ||
| useUnifiedTopology: { type: 'boolean' } as OptionDescriptor |
Contributor
Author
There was a problem hiding this comment.
And here that's supporting the old options. These still aren't listed in the props for MongoClientOptions (which is why we have the as casting). I would add that they are deprecated but then our CSFLE lib would emit the warnings with no way to disable.
ljhaywar
pushed a commit
that referenced
this pull request
Nov 9, 2021
Permits legacy options being used by mongodb-client-encryption's use of the MongoClient constructor. Permits legacy WC option style in insertOne. NODE-3006
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Permits legacy options being used by mongodb-client-encryption's
use of the MongoClient constructor. Permits legacy WC option style in
insertOne.
NODE-3006
CSFLE Tests Patch