fix: make tryNext and Batch public#2675
Merged
Merged
Conversation
mbroadst
suggested changes
Dec 13, 2020
nbbeeken
approved these changes
Dec 14, 2020
mbroadst
reviewed
Dec 15, 2020
Member
mbroadst
left a comment
mbroadst
left a comment
There was a problem hiding this comment.
This LGTM with one nitpick. It might also be worth filing a ticket for duplicate maybePromise: ChangeStream#next|tryNext|hasNext all are top-level API which ultimately delegate to the underlying cursor (if possible) so maybePromise is called twice in the happy path. It may be possible to refactor the cursors to allow you to bypass one of those calls
emadum
commented
Dec 15, 2020
mbroadst
approved these changes
Dec 16, 2020
Member
mbroadst
left a comment
mbroadst
left a comment
There was a problem hiding this comment.
LGTM, mod one comment about the use of mocha's --exit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes the
tryNextiteration helper on cursors and change streams.NODE-2952