Skip to content

Conversation

@emadum
Copy link
Contributor

@emadum emadum commented Nov 3, 2020

Description

This PR fixes a bug in Kerberos authentication by moving the Kerberos
client initialization from the AuthProvider.prepare override into a
local makeKerberosClient function.

NODE-2859

What changed?

Are there any files to ignore?

Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mbroadst mbroadst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, mod a naming nitpick

@mbroadst mbroadst changed the title fix: move client setup from prepare to auth fix: move kerberos client setup from prepare to auth Nov 5, 2020
@mbroadst mbroadst merged commit 033b6e7 into 3.6 Nov 6, 2020
@mbroadst mbroadst deleted the NODE-2859/kerberos-client-fix branch November 6, 2020 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants