docs(examples): updating examples to use async/await #1764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrites all the test examples to use async/await. They are now located in a separate folder that only runs when the node version supports async/await Fixes NODE-1533
daprahamian
force-pushed
the
NODE-1533/rewrite-examples
branch
from
6bca8b0 to
a7c6350
Compare
daprahamian
changed the title
mbroadst
approved these changes
Jul 2, 2018
Member
mbroadst
left a comment
mbroadst
left a comment
There was a problem hiding this comment.
LGTM, with a general nitpick that the headers for individual cases are inconsistent in capitalization
test/examples/causal_consistency.js
Outdated
| collection = undefined; | ||
| }); | ||
|
|
||
| it('CausalConsistency', { |
Member
There was a problem hiding this comment.
seems a little inconsistent (pun intended), maybe it('supports causal consistency', ...) ?
Member
|
also, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrites all the test examples to use async/await. They
are now located in a separate folder that only runs
when the node version supports async/await
Fixes NODE-1533
WIP b/c I have to add transaction testsTransaction tests are added. Would be nice to disableconsole.logs in there. Also, we should check that the new file locations are good for docs.