docs(array filter): add example using array filters #1647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daprahamian
approved these changes
Jan 22, 2018
mbroadst
suggested changes
Jan 22, 2018
Member
mbroadst
left a comment
mbroadst
left a comment
There was a problem hiding this comment.
These should be in operation_example_tests.js, operation_generators_example_tests.js, operation_promises_example_tests.js (modified per variant) instead. It made sense to put all the changestreams in one file because there were a few, but this is a single test.
mbroadst
reviewed
Jan 22, 2018
| const db = client.db(configuration.db); | ||
| const collection = db.collection('arrayFilterUpdateExample'); | ||
|
|
||
| // 3. Exploiting the power of arrays |
Member
There was a problem hiding this comment.
also does this line need a corresponding end tag?
Contributor
Author
There was a problem hiding this comment.
I will check with the docs team 👍
Contributor
Author
|
I have moved the example to
|
daprahamian
reviewed
Jan 23, 2018
test/functional/examples_tests.js
Outdated
| } | ||
| }); | ||
|
|
||
| it.only('supports array filters when updating', { |
This was referenced Mar 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an example of using
arrayFiltersin an update for the docs team.Fixes NODE-1263