Add optional dependencies, forwarding them to pymongo#38
Add optional dependencies, forwarding them to pymongo#38arthurdarcet wants to merge 1 commit intomongodb:masterfrom
Conversation
|
Not sure if this would be the same behaviour using pypi but it doesn't seem to work locally. $ pip install -U -e .[srv]
Obtaining file:///***/***/motor
motor 1.3.dev0 does not provide the extra 'srv'
Collecting pymongo<4,>=3.4 (from motor==1.3.dev0)
Using cached pymongo-3.6.1-cp35-cp35m-macosx_10_6_intel.whl
Installing collected packages: pymongo, motor
Running setup.py develop for motor
Successfully installed motor pymongo-3.6.1
$ pip freeze
-e git+git@github.com:eguven/motor.git@1a5055d06391e779f27ca6cc1e8c7ea01c59baad#egg=motor
pymongo==3.6.1 |
|
@eguven there was indeed a typo in my commit, which I fixed. |
|
Actually, the issue already exists on pip: pypa/pip#3878 |
|
OK, if this feature doesn't work with pip today, it will be a long time before we can rely on all pip users to have upgraded to a version of pip that supports it. A few years minimum. Thanks for your work, unfortunately I can't accept this PR. |
pymongosupports three optional dependencies, it would be nice to support them as well here, so that we can depend directly onmotor[srv]instead of having to list bothmotorandpymongo[srv]