-
Notifications
You must be signed in to change notification settings - Fork 55
CLOUDP-366183: Bump Ops Manager Container Image version to 7.0.21 and fix image usage #671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
49b82a7
Updated files
mms-build-account 49959b9
Run pre-commit hook
b9ed5bb
Merge branch 'master' into CLOUDP-366183_om_image_version_bump
lsierant daa8931
use ecr images
nammn 70ed9f5
use ecr images
nammn c74c8df
use ecr images
nammn 768a32a
try olm fix
nammn 06ca827
make release_om_and_agents run first before the rest
nammn 30114be
linter
nammn 1adf2aa
agent also in stable
nammn b9c79c8
meko vs mck upgrades
nammn bb56ff4
fix agent construction
nammn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -961,6 +961,25 @@ def install_official_operator( | |
| "operator.mdbDefaultArchitecture": operator_installation_config["operator.mdbDefaultArchitecture"], | ||
| } | ||
|
|
||
| # For upgrade tests in patch builds, we need to use ECR registries for workload images | ||
| # (OpsManager, Agent, etc.) since new versions may not be released to quay.io yet. | ||
| # The operator itself still comes from the official helm chart, but resources it creates | ||
| # should use the dev registries where unreleased images are available. | ||
| # For staging/release builds, images are already published to quay.io, so we use quay.io | ||
| # to verify the actual public release path. | ||
| build_scenario = operator_installation_config.get("buildScenario", "") | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. helm charts: priorly failing now passing using ecr: |
||
| if build_scenario == "patch": | ||
| logger.debug("Patch build detected: using ECR registries for workload images in upgrade tests") | ||
| # Override OM registry for ALL operators (including legacy) - OM version tags are standard (e.g., 7.0.21) | ||
|
nammn marked this conversation as resolved.
|
||
| if "registry.opsManager" in operator_installation_config: | ||
| helm_args["registry.opsManager"] = operator_installation_config["registry.opsManager"] | ||
|
|
||
| # Only override Agent registry for current operator (not legacy) because legacy operators | ||
| # use different agent tag formats (e.g., 13.21.0.9059-1_1.27.0) that don't exist in ECR. | ||
| # Init images are already released to quay.io and don't need ECR override. | ||
| if custom_operator_version is None and "registry.agent" in operator_installation_config: | ||
| helm_args["registry.agent"] = operator_installation_config["registry.agent"] | ||
|
|
||
| # Note, that we don't intend to install the official Operator to standalone clusters (kops/openshift) as we want to | ||
| # avoid damaged CRDs. But we may need to install the "openshift like" environment to Kind instead of the "ubi" | ||
| # images are used for installing the dev Operator | ||
|
|
@@ -1008,9 +1027,9 @@ def install_official_operator( | |
| "multiCluster.clusters": operator_installation_config["multiCluster.clusters"], | ||
| } | ||
| ) | ||
| # The "official" Operator will be installed, from the Helm Repo ("mongodb/enterprise-operator") | ||
| # We pass helm_args as operator installation config below instead of the full configmap data, otherwise | ||
| # it overwrites registries and image versions, and we wouldn't use the official images but the dev ones | ||
| # The "official" Operator will be installed from the Helm Repo ("mongodb/enterprise-operator") | ||
| # but workload images (OpsManager, Agent, etc.) will use dev registries from operator_installation_config | ||
| # to support testing unreleased versions in patch builds. | ||
| return _install_multi_cluster_operator( | ||
| namespace, | ||
| helm_args, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this and on other places should ensure that this task runs on master merges first before running the tests, at the same time it won't run on patches as the task doesn't exist (hence the optional setting)