CLOUDP-366183: Bump Ops Manager Container Image version to 7.0.21#648
CLOUDP-366183: Bump Ops Manager Container Image version to 7.0.21#648mms-build-account wants to merge 3 commits intomasterfrom
Conversation
MCK 1.6.2 Release NotesBug Fixes
|
lsierant
added
the
skip-changelog
| "agent_version": "108.0.16.8895-1", | ||
| "tools_version": "100.13.0" | ||
| }, | ||
| "7.0.21": { |
There was a problem hiding this comment.
one thing that I noticed is, this mapping of OM version and agent/tools version should be sorted as we can see the the older version is already sorted.
So ideally 7.0.21 should be before 8.0.1 and after 7.0.20 above in the list.
There was a problem hiding this comment.
Keys in objects are are unordered in JS. I think we've been manually ordering these before (I certainly did move 7.0.20 up when I was rebasing 7.0.20 bump PR).
But I think it is just for human convenience. Order should not affect anything else.
There was a problem hiding this comment.
But I think it is just for human convenience. Order should not affect anything else.
Actually we do rely on the order of the elements at some places in our code, not for this exact field (mongodb-agent.opsManagerMapping.ops_manager) but for example supportedImages.ops-manager.versions. This is one example.
There was a problem hiding this comment.
@viveksinghggits supportedImages.ops-manager.versions is different - it is a list and it is ok to rely on order there (assuming that we update the order correctly.
But in our scripts we should not rely on the ordering of keys in objects even if they are ordered in json. And, as far as I understand, it is what you fixed in #668 with sorting.
… fix image usage (#671) # Summary This PR fixes upgrade/OLM tests failing in patch builds when testing unreleased OpsManager versions (e.g., 7.0.21) that don't exist on quay.io yet. ## Problem When PR #648 bumped OM from 7.0.20 to 7.0.21, upgrade tests started failing with: ``` Failed to pull image "quay.io/mongodb/mongodb-enterprise-ops-manager-ubi:7.0.21": image not found ``` **Root Cause:** In patch builds, images are published to ECR (dev registry) but not yet to quay.io. Upgrade tests install released operators (from official Helm charts or OLM) which default to quay.io registries. ## Solution Pass ECR registry configuration to upgrade tests in patch builds: ### Helm-based Upgrade Tests (`install_official_operator`) - **OM Registry (`registry.opsManager`)**: Passed to ALL operators (including legacy like 1.27.0, 1.32.0) because OM version tags are standard (e.g., `7.0.21`) - **Agent Registry (`registry.agent`)**: Only passed to current/dev operator, NOT legacy operators because they use different tag formats (e.g., `13.21.0.9059-1_1.27.0`) that don't exist in ECR ### OLM Upgrade Tests (subscription config) - Added `get_registry_env_vars_for_subscription()` helper in `olm_test_commons.py` - Only passes `OPS_MANAGER_IMAGE_REPOSITORY` env var (not agent registry) because: 1. Released operators may use different agent tag formats 2. OLM subscription env vars persist across channel upgrades ## Proof of Work - green pr ## Checklist - [x] Have you linked a jira ticket and/or is the ticket in the title? - [ ] Have you checked whether your jira ticket required DOCSP changes? - [x] Have you added changelog file? - use `skip-changelog` label if not needed - refer to [Changelog files and Release Notes](https://github.com/mongodb/mongodb-kubernetes/blob/master/CONTRIBUTING.md#changelog-files-and-release-notes) section in CONTRIBUTING.md for more details --------- Co-authored-by: mms-build-account <mms-admin+pullonly@10gen.com> Co-authored-by: Evergreen <kubernetes-hosted-team@mongodb.com> Co-authored-by: Łukasz Sierant <lukasz.sierant@mongodb.com>
|
fixed by #671 |
5 participants
Opened by Private Cloud Tools (PCT).
Ticket
CLOUDP-366183
Description
Bump Ops Manager container image version to 7.0.21.
Reviewer Checklist
Before merging this PR, verify the following:
publish_ops_managertask (variant:publish_om70_images)agent_versionwas updated correctlytools_versionwas updated correctly