fix split environment variables on helm chart template #522
+8
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix environment variable parsing in Helm chart template to properly handle values containing equals signs.
The previous implementation used
split "=" .
which would incorrectly parse environment variables with values containing=
characters (e.g.,VAR=value=with=equals
). Changed to usesplitn "=" 2 .
which limits the split to 2 parts, treating everything after the first=
as the value.Proof of Work
The fix changes the parsing logic in
helm_chart/templates/operator.yaml:280-281
:split "=" .
- splits on all=
characterssplitn "=" 2 .
- splits only on the first=
, preserving=
in valuesThis ensures custom environment variables with values containing
=
characters are correctly parsed when using.Values.customEnvVars
.Validation:
helm template helm_chart --set customEnvVars='CLUSTER_DOMAIN=mydomain.local&MY_VAR1=mylabel=abc&MY_VAR2=any'
The rendered output correctly shows:
Checklist