Implement option to override id of replicaSet (see #1650) #1656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1st8
requested review from
Julien-Ben,
MaciejKaras,
fealebenpae,
lsierant,
lucian-tosa,
mircea-cosbuc and
nammn
as code owners
Contributor
|
This PR is being marked stale because it has been open for 60 days with no activity. Please update the PR or ask for a fresh review. |
Contributor
Author
|
Still affecting us, the solution in the PR is working nicely. |
MaciejKaras
approved these changes
Apr 1, 2025
Collaborator
MaciejKaras
left a comment
MaciejKaras
left a comment
There was a problem hiding this comment.
I like that you didn't change existing logic, but added a way to override it if necessary.
PR looks good, thanks for your contribution!
mircea-cosbuc
added
the
safe-to-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1650
Summary:
This PR adds a new optional string property in OverrideReplicaSet, which can be used to set the
_idof the generated replicaSet config. See #1650 for details of the use case.I implemented it as a new property in order to not break any existing setups or the default behaviour.
The change has been verified with a test and also by deploying the modified operator to our environment, where it achieves the desired result.
All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if such).