Skip to content

Allow PHP 8 to be installed#786

Closed
vasilvestre wants to merge 1 commit intomongodb:masterfrom
vasilvestre:patch-1
Closed

Allow PHP 8 to be installed#786
vasilvestre wants to merge 1 commit intomongodb:masterfrom
vasilvestre:patch-1

Conversation

@vasilvestre
Copy link
Copy Markdown

@vasilvestre vasilvestre commented Sep 15, 2020

Allowing PHP 8 on master branch could allow people on dev channel to report issues on it.

What do you think about this ?

Actual problem accoding to alcaeus is that mongo-php-driver isn't ready yet. mongodb/mongo-php-driver#1161

@alcaeus
Copy link
Copy Markdown
Member

alcaeus commented Sep 15, 2020

Correct. Once we have the driver supporting PHP 8, we'll also allow installing this library on PHP 8, which also allows Doctrine MongoDB ODM to test PHP 8 support.

@itisjoby
Copy link
Copy Markdown

any update on this issue?

@vasilvestre vasilvestre reopened this Feb 26, 2021
@vasilvestre
Copy link
Copy Markdown
Author

vasilvestre commented Feb 26, 2021

"php": "^7.0 || ^8.0" is the actual value in 78e3606#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34
so this is fine. #793 fixed it

@vasilvestre vasilvestre mentioned this pull request Feb 26, 2021
@vasilvestre vasilvestre deleted the patch-1 branch February 26, 2021 07:38
@alcaeus
Copy link
Copy Markdown
Member

alcaeus commented Feb 26, 2021

@itisjoby the 1.8.0 release of this library, along with the corresponding 1.9.0 release of ext-mongodb introduced compatibility with PHP 8 and was released in November. I apologise for not posting an update in every ticket that mentioned PHP 8 support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants