Skip to content

Assert initial resume token in resumeAfter test#676

Merged
alcaeus merged 1 commit intomasterfrom
jmikola-patch-1
Sep 2, 2019
Merged

Assert initial resume token in resumeAfter test#676
alcaeus merged 1 commit intomasterfrom
jmikola-patch-1

Conversation

@jmikola
Copy link
Copy Markdown
Contributor

@jmikola jmikola commented Sep 2, 2019

ChangeStream::getResumeToken() did not exist at the time this test was written; however, we do this assertion in testStartAfterOption().

This was originally suggested in #659, but fell out as a related change to testStartAfterOption() was no longer needed.

ChangeStream::getResumeToken() did not exist at the time this test was written; however, we do this assertion in testStartAfterOption().
@jmikola jmikola requested a review from alcaeus September 2, 2019 14:32
Copy link
Copy Markdown
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

alcaeus added a commit that referenced this pull request Sep 2, 2019
@alcaeus alcaeus merged commit 6bf0671 into master Sep 2, 2019
@jmikola jmikola deleted the jmikola-patch-1 branch September 2, 2019 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants