PHPLIB-1710: Remove dead local .evergreen config#1766
PHPLIB-1710: Remove dead local .evergreen config#1766paulinevos merged 4 commits intomongodb:v2.xfrom
.evergreen config#1766Conversation
As it seems to be covered by the `drivers-evergreen-tools` submodule, which is loaded in evergreen functions and GH actions (added in PR `mongodb#1584`)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2.x #1766 +/- ##
=========================================
Coverage 87.72% 87.72%
Complexity 3190 3190
=========================================
Files 424 424
Lines 6348 6348
=========================================
Hits 5569 5569
Misses 779 779
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f7c5a92 to
04d7a27
Compare
|
I think there are some additional changes that can be applied and tested:
|
|
@jmikola What I don't understand re: the |
Its contents don't seem to be used
It doesn't appear to be referenced locally anymore, only internally in the drivers-evergreen-tools submodule
.evergreen/ocsp directory.evergreen/ocsp directory
|
@jmikola Oh actually, they aren't references to the local one at all: I'll see if they're referenced anywhere else and otherwise remove |
There's no need for it locally as it's covered by the `drivers-everygreen-tools` submodule
jmikola
left a comment
There was a problem hiding this comment.
Thanks, I missed the cd command in functions.yml.
Changes LGTM. I'll defer to you on the tests.yml change.
And please revise the PR title before squash-merging, since the PR addresses more than just OCSP.
.evergreen/ocsp directory.evergreen config
As it's covered by the
drivers-evergreen-toolssubmodule now.