PHPLIB-1568 Add GridFS\Bucket::deleteByName(filename) and renameByName(filename, newFilename)#1504
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * Updates the filename field in the file document for all the files with a given filename. | ||
| */ | ||
| public function updateFilenameForFilename(string $filename, string $newFilename): ?int | ||
| public function updateFilenameForFilename(string $filename, string $newFilename): int |
Check notice
Code scanning / Psalm
InvalidNullableReturnType
| * Updates the filename field in the file document for all the files with a given filename. | ||
| */ | ||
| public function updateFilenameForFilename(string $filename, string $newFilename): ?int | ||
| public function updateFilenameForFilename(string $filename, string $newFilename): int |
There was a problem hiding this comment.
The class is internal, we can change the return type. This is always an int, an exception is thrown in case of error.
| ['filename' => $filename], | ||
| ['$set' => ['filename' => $newFilename]], | ||
| )->getMatchedCount()]]></code> | ||
| </NullableReturnStatement> |
There was a problem hiding this comment.
Boths additions will be removed in v2.x, thanks to #1454
| $filename = $filename; | ||
| $revision = $revision; |
There was a problem hiding this comment.
I thought I had already removed that.
There was a problem hiding this comment.
Noted that this remained when 1b29a6d introduced type hints on the method.
GromNaN
changed the title
GridFS\Bucket::deleteByName(filename)GridFS\Bucket::deleteByName(filename) and renameByName(filename, newFilename)
| $filename = $filename; | ||
| $revision = $revision; |
There was a problem hiding this comment.
Noted that this remained when 1b29a6d introduced type hints on the method.
| $this->assertCollectionCount($this->chunksCollection, 0); | ||
| } | ||
|
|
||
| public function testDeleteByName(): void |
There was a problem hiding this comment.
Should this Pr block on spec changes for DRIVERS-2807 and DRIVERS-2808? Also, will the PR(s) for those tickets include spec tests to be synced?
There was a problem hiding this comment.
Spec tests added in mongodb/specifications#1702
GromNaN
force-pushed
the
PHPLIB-1568
branch
3 times, most recently
from
b9d5dc0 to
a955d57
Compare
| * Delete all GridFS files and chunks for a given filename. | ||
| */ | ||
| public function deleteFileAndChunksByFilename(string $filename): ?int | ||
| public function deleteFileAndChunksByFilename(string $filename): int |
Check notice
Code scanning / Psalm
InvalidNullableReturnType
2 participants
Fix PHPLIB-1568
GridFS\Bucket::deleteByName($filename)Use the
CollectionWrapper::deleteFileAndChunksByFilename()introduced for the need of theStreamWrapper::unlink().unlinkfor GridFS stream wrapper #1206Implementation:
If a DB error occurs during 1, nothing happened.
If a DB error occurs during 2 or 3, some chunks may become orphan and we cannot retry as the mapping chunks-id-to-file-name is missing.
There could be an issue if the list of ids is too big. In that case, we would have to work by batches.
GridFS\Bucket::renameByName($filename)Use the
CollectionWrapper::updateFilenameForFilename()introduced for the need ofStreamWrapper::rename()renamefor GridFS stream wrapper #1207Implementation: