PHPC-2661: Use php-windows-builder for Windows extension builds #1907
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,99 @@ | ||
| name: "Build Windows Packages" | ||
| run-name: "Build Windows Packages for ${{ inputs.ref }}" | ||
|
|
||
| on: | ||
| workflow_call: | ||
| inputs: | ||
| version: | ||
| description: "The version being built" | ||
| type: string | ||
| required: true | ||
| ref: | ||
| description: "The git reference to build" | ||
| type: string | ||
| required: true | ||
| upload_release_assets: | ||
| description: "Whether to upload assets to a GitHub release" | ||
| type: boolean | ||
| default: false | ||
|
|
||
| jobs: | ||
| build: | ||
| name: "Build DLL" | ||
| runs-on: ${{ matrix.os }} | ||
| defaults: | ||
| run: | ||
| shell: cmd | ||
|
|
||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| os: [ "windows-2022" ] | ||
| # Note: keep this in sync with the Windows matrix in tests.yml | ||
| php-version: | ||
| - "8.1" | ||
| - "8.2" | ||
| - "8.3" | ||
| - "8.4" | ||
| arch: [ x64, x86 ] | ||
| ts: [ ts, nts ] | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| submodules: true | ||
| ref: ${{ inputs.ref }} | ||
|
|
||
| - name: "Build Driver" | ||
| id: build-driver | ||
| uses: ./.github/actions/windows/build | ||
| with: | ||
| ref: ${{ inputs.ref }} | ||
| php-version: ${{ matrix.php-version }} | ||
| arch: ${{ matrix.arch }} | ||
| ts: ${{ matrix.ts }} | ||
| run-tests: false | ||
|
Contributor
There was a problem hiding this comment. Here you are passing a bool and overriding the default string value ( |
||
|
|
||
| sign-and-upload: | ||
| environment: release | ||
| name: "Sign and create package" | ||
| needs: build | ||
| runs-on: "ubuntu-latest" | ||
| permissions: | ||
| id-token: write | ||
|
|
||
| steps: | ||
| - name: "Generate token and checkout repository" | ||
| uses: mongodb-labs/drivers-github-tools/secure-checkout@v2 | ||
| with: | ||
| app_id: ${{ vars.APP_ID }} | ||
| private_key: ${{ secrets.APP_PRIVATE_KEY }} | ||
| ref: ${{ inputs.ref }} | ||
|
|
||
| - name: "Set up drivers-github-tools" | ||
| uses: mongodb-labs/drivers-github-tools/setup@v2 | ||
| with: | ||
| aws_role_arn: ${{ secrets.AWS_ROLE_ARN }} | ||
| aws_region_name: ${{ vars.AWS_REGION_NAME }} | ||
| aws_secret_id: ${{ secrets.AWS_SECRET_ID }} | ||
|
|
||
| - name: Get artifacts | ||
| uses: actions/download-artifact@v5 | ||
| with: | ||
| path: artifacts | ||
| pattern: php_mongodb-*.zip | ||
| merge-multiple: true | ||
|
|
||
| - name: "Create detached signatures for packages" | ||
| uses: mongodb-labs/drivers-github-tools/gpg-sign@v2 | ||
| with: | ||
| filenames: php_mongodb*.zip | ||
|
|
||
| - name: "Move signatures from release assets folder" | ||
| run: | | ||
| mv ${RELEASE_ASSETS}/php_mongodb*.sig artifacts/ | ||
|
|
||
| - name: "Upload assets to release" | ||
| if: ${{ inputs.upload_release_assets }} | ||
| run: | | ||
| gh release upload ${{ inputs.version }} artifacts/php_mongodb* --clobber | ||
|
Contributor
There was a problem hiding this comment. Probably not necessary but you could restrict the extension to "zip" and "sig". I assume the directory starts empty, though. |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why a string value instead of a bool?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inputs for composite actions are always strings, I wanted to make this explicit here.