PHPC-2627: Use appropriate return type for zend_object_iterator_funcs.valid#1890
Merged
jmikola merged 1 commit intomongodb:v2.xfrom Oct 15, 2025
Merged
PHPC-2627: Use appropriate return type for zend_object_iterator_funcs.valid#1890jmikola merged 1 commit intomongodb:v2.xfrom
jmikola merged 1 commit intomongodb:v2.xfrom
Conversation
GromNaN
reviewed
Oct 14, 2025
Member
GromNaN
left a comment
GromNaN
left a comment
There was a problem hiding this comment.
LGTM.
Is it a bugfix to backport to 2.1 or even 1.21?
Contributor
Author
|
No need to backport. This is just addressing a build warning that has been present for some time already. |
GromNaN
approved these changes
Oct 14, 2025
alcaeus
added a commit
that referenced
this pull request
Jan 21, 2026
* v2.x: (39 commits) Bump tests/drivers-evergreen-tools from `61cb4e9` to `5514d6a` (#1908) Bump tests/drivers-evergreen-tools from `514927f` to `61cb4e9` (#1906) Bump tests/drivers-evergreen-tools from `ebe98d0` to `514927f` (#1905) PHPC-2649: Update to libmongocrypt 1.17.0 (#1904) PHPC-2654: Update to libmongoc 2.2.1 (#1900) Bump tests/drivers-evergreen-tools from `c92d062` to `ebe98d0` (#1903) Bump actions/cache from 4 to 5 (#1902) Bump tests/drivers-evergreen-tools from `c83e428` to `c92d062` (#1899) Bump tests/drivers-evergreen-tools from `cb019f7` to `c83e428` (#1898) Bump actions/checkout from 5 to 6 (#1895) Bump tests/drivers-evergreen-tools from `f8ab2a5` to `cb019f7` (#1896) PHPC-2634: Binary vector corpus tests (#1892) Bump tests/drivers-evergreen-tools from `1dcbfe4` to `f8ab2a5` (#1891) PHPC-2638 and PHPC-2630: Bump to libmongoc 2.1.2 and libmongocrypt 1.16.0 (#1868) Fix git submodule command in CONTRIBUTING.md PHPC-2627: Use appropriate return type for zend_object_iterator_funcs.valid (#1890) Bump github/codeql-action from 3 to 4 (#1889) Bump tests/drivers-evergreen-tools from `3b3f081` to `1dcbfe4` (#1878) PHPC-2474: Support Binary vector subtype (#1853) Upload test results to codecov.io (#1857) ...
alcaeus
added a commit
that referenced
this pull request
Jan 28, 2026
* v2.x: (40 commits) PHPC-2664: Drop Windows x86 builds (#1911) Bump tests/drivers-evergreen-tools from `61cb4e9` to `5514d6a` (#1908) Bump tests/drivers-evergreen-tools from `514927f` to `61cb4e9` (#1906) Bump tests/drivers-evergreen-tools from `ebe98d0` to `514927f` (#1905) PHPC-2649: Update to libmongocrypt 1.17.0 (#1904) PHPC-2654: Update to libmongoc 2.2.1 (#1900) Bump tests/drivers-evergreen-tools from `c92d062` to `ebe98d0` (#1903) Bump actions/cache from 4 to 5 (#1902) Bump tests/drivers-evergreen-tools from `c83e428` to `c92d062` (#1899) Bump tests/drivers-evergreen-tools from `cb019f7` to `c83e428` (#1898) Bump actions/checkout from 5 to 6 (#1895) Bump tests/drivers-evergreen-tools from `f8ab2a5` to `cb019f7` (#1896) PHPC-2634: Binary vector corpus tests (#1892) Bump tests/drivers-evergreen-tools from `1dcbfe4` to `f8ab2a5` (#1891) PHPC-2638 and PHPC-2630: Bump to libmongoc 2.1.2 and libmongocrypt 1.16.0 (#1868) Fix git submodule command in CONTRIBUTING.md PHPC-2627: Use appropriate return type for zend_object_iterator_funcs.valid (#1890) Bump github/codeql-action from 3 to 4 (#1889) Bump tests/drivers-evergreen-tools from `3b3f081` to `1dcbfe4` (#1878) PHPC-2474: Support Binary vector subtype (#1853) ...
alcaeus
added a commit
that referenced
this pull request
Jan 28, 2026
* v2.x: (40 commits) PHPC-2664: Drop Windows x86 builds (#1911) Bump tests/drivers-evergreen-tools from `61cb4e9` to `5514d6a` (#1908) Bump tests/drivers-evergreen-tools from `514927f` to `61cb4e9` (#1906) Bump tests/drivers-evergreen-tools from `ebe98d0` to `514927f` (#1905) PHPC-2649: Update to libmongocrypt 1.17.0 (#1904) PHPC-2654: Update to libmongoc 2.2.1 (#1900) Bump tests/drivers-evergreen-tools from `c92d062` to `ebe98d0` (#1903) Bump actions/cache from 4 to 5 (#1902) Bump tests/drivers-evergreen-tools from `c83e428` to `c92d062` (#1899) Bump tests/drivers-evergreen-tools from `cb019f7` to `c83e428` (#1898) Bump actions/checkout from 5 to 6 (#1895) Bump tests/drivers-evergreen-tools from `f8ab2a5` to `cb019f7` (#1896) PHPC-2634: Binary vector corpus tests (#1892) Bump tests/drivers-evergreen-tools from `1dcbfe4` to `f8ab2a5` (#1891) PHPC-2638 and PHPC-2630: Bump to libmongoc 2.1.2 and libmongocrypt 1.16.0 (#1868) Fix git submodule command in CONTRIBUTING.md PHPC-2627: Use appropriate return type for zend_object_iterator_funcs.valid (#1890) Bump github/codeql-action from 3 to 4 (#1889) Bump tests/drivers-evergreen-tools from `3b3f081` to `1dcbfe4` (#1878) PHPC-2474: Support Binary vector subtype (#1853) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-2627
See: https://github.com/php/php-src/blob/571bded46ece6922f0bef0d135986786e9b49029/UPGRADING.INTERNALS#L29-L31