Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the compiler variant in Windows release file names for PHP 8.3 #1718

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented Oct 11, 2024

Rebasing #1717 on v1.20.

Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I created PHPC-2469 to switch our release actions to use the output variable from setup-php-sdk to avoid having to update the list for every new PHP version.

@jmikola jmikola merged commit 1766af8 into v1.20 Oct 14, 2024
79 checks passed
@jmikola jmikola deleted the windows-php-8.3-binaries branch October 14, 2024 15:01
This was referenced Oct 14, 2024
@mickverm
Copy link
Contributor

@alcaeus please take the following into account when updating the release actions: https://github.com/php/pie/blob/main/docs/extension-maintainers.md#windows-support

I figured out that the package should be named x86_64 instead of x64 and that the name of the .dll also doesn't follow their spec.

@alcaeus
Copy link
Member

alcaeus commented Oct 17, 2024

Thanks for pointing this out. I've created #1732 to use the setup-php-sdk output and change the filename of the .dll and .zip files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants