PHPC-2348 Remove WriteException and move getWriteResult to BulkWriteException#1685
Merged
GromNaN merged 2 commits intomongodb:v2.xfrom Sep 24, 2024
Merged
PHPC-2348 Remove WriteException and move getWriteResult to BulkWriteException#1685GromNaN merged 2 commits intomongodb:v2.xfrom
WriteException and move getWriteResult to BulkWriteException#1685GromNaN merged 2 commits intomongodb:v2.xfrom
Conversation
GromNaN
commented
Sep 24, 2024
alcaeus
approved these changes
Sep 24, 2024
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Oct 22, 2024
…db v2 (GromNaN) This PR was merged into the 5.4 branch. Discussion ---------- [HttpFoundation][Lock] Ensure compatibility with ext-mongodb v2 | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT The extension `mongodb` and the library `mongodb/mongodb` will soon have a version 2.0 that brings breaking changes (see [extension changes](https://jira.mongodb.org/browse/PHPC-2445) and [library changes](https://jira.mongodb.org/browse/PHPLIB-1332)). This PR ensures compatibility with the upcoming version for Symfony 5.4. - Return types added to `MongoDB\Collection::updateOne()`, the closure in the mock `willReturnCallback` must return an object. mongodb/mongo-php-library#1391 - `MongoDB\Driver\Exception\WriteException` removed in favor of `BulkWriteException` mongodb/mongo-php-driver#1685. No need to keep catching `WriteException` since a the driver bulk API have always be used. - `float` support to construct `MongoDB\BSON\UTCDateTime` is removed mongodb/mongo-php-driver#1709 Commits ------- 81366bf Ensure compatibility with mongodb v2
alcaeus
added a commit
that referenced
this pull request
Oct 29, 2024
* v2.x: (22 commits) PHPC-2441: Remove deprecated Manager constructor options (#1719) PHPC-990: Strict type validation for boolean URI options (#1713) PHPC-2440: Remove deprecated Query constructor options (#1707) PHPC-2459: Remove support for float arg in UTCDateTime ctor (#1709) Remove obsolete test PHPC-2344 Remove SSLConnectionException (#1696) PHPC-2144 Throw a LogicException when getting info from unacknowledged write result (#1687) PHPC-2454: Remove --enable-system-ciphers configure option (#1681) PHPC-2348 Remove `WriteException` and move `getWriteResult` to `BulkWriteException` (#1685) PHPC-2417 Add UTCDateTimeInterface::toDateTimeImmutable() (#1684) PHPC-2309: Remove --with-openssl-dir configure option (#1676) PHPC-2444: Remove support for string arguments in UTCDateTime constructor (#1662) PHPC-2248: Remove Serializable implementations (#1663) Update version for 2.x branch (#1672) PHPC-1021: Remove support for ReadPreference integer modes (#1666) PHPC-2342: Remove --with-libbson and --with-libmongoc configure options (#1667) PHPC-2351: Remove CursorId class (#1664) PHPC-2140: Make tentative return types definitive (#1658) PHPC-2402: Remove range_preview constants (#1665) PHPC-2346: Remove deprecated BSON functions (#1653) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix PHPC-2348
The method
WriteException::getWriteResult()is now attached toBulkWriteException.