PHP-1741: Remove getServer from APM event classes#1652
Merged
alcaeus merged 3 commits intomongodb:v2.xfrom Sep 18, 2024
Merged
Conversation
This also removes the internal Manager reference.
alcaeus
reviewed
Sep 17, 2024
Member
alcaeus
left a comment
alcaeus
left a comment
There was a problem hiding this comment.
Changes look good, but there's a leftover field in the command event structs that's no longer needed.
| } | ||
|
|
||
| if (!Z_ISUNDEF(intern->manager)) { | ||
| zval_ptr_dtor(&intern->manager); |
Member
There was a problem hiding this comment.
You can also remove the manager field from the corresponding struct as it's no longer used. Same applies to the other command event structs.
Contributor
Author
There was a problem hiding this comment.
Ah, thanks for catching that ✌️
alcaeus
approved these changes
Sep 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-1741
This also removes the internal Manager reference.