Make reference count check atomic with release #876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyemin
commented
Feb 10, 2022
| import static com.mongodb.connection.ClusterType.LOAD_BALANCED; | ||
|
|
||
| public class ClientSessionBinding implements AsyncReadWriteBinding { | ||
| public class ClientSessionBinding extends AbstractReferenceCounted implements AsyncReadWriteBinding { |
There was a problem hiding this comment.
It might have been overkill to change this class since it doesn't need to be thread safe, but once I marked getCount as VisibleForTesting(otherwise=PRIVATE) I didn't want to use it any more in production code. But take a close look because my initial attempts here were buggy and caused unit tests to fail.
| } | ||
|
|
||
| private void closeSessionIfCountIsZero() { | ||
| if (getCount() == 0 && ownsSession) { |
There was a problem hiding this comment.
Stop using getCount and instead give this class its own reference count so that release can properly close the session.
|
|
||
| @Override | ||
| public ConnectionDescription getDescription() { | ||
| isTrue("open", getCount() > 0); |
There was a problem hiding this comment.
Just get rid of superfluous use of getCount
stIncMale
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JAVA-4490