Skip to content

Enable test of nsType with a collection view #1702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025
Merged

Enable test of nsType with a collection view #1702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedCrudHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1381,10 +1381,10 @@ public OperationResult executeCreateCollection(final BsonDocument operation) {
// In Java driver there is a separate method for creating a view, but in the unified test CRUD format
// views and collections are both created with the createCollection operation. We use the createView
// method if the requisite arguments are present.
if (arguments.containsKey("viewOn") && arguments.containsKey("pipeline")) {
if (arguments.containsKey("viewOn")) {
String viewOn = arguments.getString("viewOn").getValue();
List<BsonDocument> pipeline =
arguments.getArray("pipeline").stream().map(BsonValue::asDocument).collect(toList());
arguments.getArray("pipeline", new BsonArray()).stream().map(BsonValue::asDocument).collect(toList());
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If no pipeline provided, use an empty one.


for (Map.Entry<String, BsonValue> cur : arguments.entrySet()) {
switch (cur.getKey()) {
Expand Down
3 changes: 0 additions & 3 deletions driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedTestModifications.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,6 @@ public static void applyCustomizations(final TestDef def) {
.test("change-streams", "change-streams-errors", "Change Stream should error when an invalid aggregation stage is passed in")
.test("change-streams", "change-streams-errors", "The watch helper must not throw a custom exception when executed against a single server topology, but instead depend on a server error");

def.skipJira("https://jira.mongodb.org/browse/JAVA-5769")
.test("change-streams", "change-streams-nsType", "nsType is present when creating views");

// client-side-operation-timeout (CSOT)

def.skipNoncompliantReactive("No good way to fulfill tryNext() requirement with a Publisher<T>")
Expand Down