Skip to content

Tests: Add support for crud tests bypassDocumentationValidation.json #1687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 1, 2025
Merged

Tests: Add support for crud tests bypassDocumentationValidation.json #1687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
807c0ea
Tests: Add support for crud tests bypassDocumentationValidation.json
rozza Apr 28, 2025
8488647
Remove noncompliance check - with the current version of specificatio…
rozza Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedCrudHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,6 +638,9 @@ OperationResult executeFindOneAndUpdate(final BsonDocument operation) {
case "arrayFilters":
options.arrayFilters(cur.getValue().asArray().stream().map(BsonValue::asDocument).collect(toList()));
break;
case "bypassDocumentValidation":
options.bypassDocumentValidation(cur.getValue().asBoolean().getValue());
break;
default:
throw new UnsupportedOperationException("Unsupported argument: " + cur.getKey());
}
Expand Down Expand Up @@ -714,6 +717,9 @@ OperationResult executeFindOneAndReplace(final BsonDocument operation) {
case "collation":
options.collation(asCollation(cur.getValue().asDocument()));
break;
case "bypassDocumentValidation":
options.bypassDocumentValidation(cur.getValue().asBoolean().getValue());
break;
default:
throw new UnsupportedOperationException("Unsupported argument: " + cur.getKey());
}
Expand Down Expand Up @@ -831,6 +837,9 @@ OperationResult executeAggregate(final BsonDocument operation) {
case "maxAwaitTimeMS":
iterable.maxAwaitTime(cur.getValue().asNumber().longValue(), TimeUnit.MILLISECONDS);
break;
case "bypassDocumentValidation":
iterable.bypassDocumentValidation(cur.getValue().asBoolean().getValue());
break;
default:
throw new UnsupportedOperationException("Unsupported argument: " + cur.getKey());
}
Expand Down Expand Up @@ -981,6 +990,9 @@ OperationResult executeInsertOne(final BsonDocument operation) {
case "comment":
options.comment(cur.getValue());
break;
case "bypassDocumentValidation":
options.bypassDocumentValidation(cur.getValue().asBoolean().getValue());
break;
default:
throw new UnsupportedOperationException("Unsupported argument: " + cur.getKey());
}
Expand Down Expand Up @@ -1018,6 +1030,9 @@ OperationResult executeInsertMany(final BsonDocument operation) {
case "comment":
options.comment(cur.getValue());
break;
case "bypassDocumentValidation":
options.bypassDocumentValidation(cur.getValue().asBoolean().getValue());
break;
default:
throw new UnsupportedOperationException("Unsupported argument: " + cur.getKey());
}
Expand Down Expand Up @@ -1062,6 +1077,9 @@ OperationResult executeBulkWrite(final BsonDocument operation) {
case "let":
options.let(cur.getValue().asDocument());
break;
case "bypassDocumentValidation":
options.bypassDocumentValidation(cur.getValue().asBoolean().getValue());
break;
default:
throw new UnsupportedOperationException("Unsupported argument: " + cur.getKey());
}
Expand Down Expand Up @@ -1192,6 +1210,9 @@ private UpdateOptions getUpdateOptions(final BsonDocument arguments) {
case "sort":
options.sort(cur.getValue().asDocument());
break;
case "bypassDocumentValidation":
options.bypassDocumentValidation(cur.getValue().asBoolean().getValue());
break;
default:
throw new UnsupportedOperationException("Unsupported argument: " + cur.getKey());
}
Expand Down Expand Up @@ -1229,6 +1250,9 @@ private ReplaceOptions getReplaceOptions(final BsonDocument arguments) {
case "sort":
options.sort(cur.getValue().asDocument());
break;
case "bypassDocumentValidation":
options.bypassDocumentValidation(cur.getValue().asBoolean().getValue());
break;
default:
throw new UnsupportedOperationException("Unsupported argument: " + cur.getKey());
}
Expand Down
2 changes: 0 additions & 2 deletions driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedTestModifications.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,8 +168,6 @@ public static void applyCustomizations(final TestDef def) {
.when(() -> def.isReactive() && UnifiedTest.Language.KOTLIN.equals(def.getLanguage()))
.file("crud", "findOne");

def.skipJira("https://jira.mongodb.org/browse/JAVA-5827")
.file("crud", "bypassDocumentValidation");
def.skipNoncompliant("Updates and Replace bulk operations are split in the java driver")
.file("crud", "bulkWrite-comment");

Expand Down