Divide ClientUpdateOptions and ClientDeleteOptions #1593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ific option adaptability. JAVA-5737
JAVA-5737
JAVA-5737
JAVA-5737
JAVA-5737
JAVA-5737
JAVA-5737
JAVA-5737
stIncMale
added a commit
to stIncMale/mongo-java-driver
that referenced
this pull request
Jan 7, 2025
stIncMale
added a commit
to stIncMale/mongo-java-driver
that referenced
this pull request
Jan 7, 2025
JAVA-5710
JAVA-5737
stIncMale
added a commit
to stIncMale/mongo-java-driver
that referenced
this pull request
Jan 8, 2025
…ptions` This allows for code reuse. mongodb#1593
stIncMale
added a commit
to stIncMale/mongo-java-driver
that referenced
this pull request
Jan 8, 2025
…ptions` This allows for code reuse. mongodb#1593
stIncMale
added a commit
to stIncMale/mongo-java-driver
that referenced
this pull request
Jan 8, 2025
…ptions` This allows for code reuse. mongodb#1593
stIncMale
requested changes
Jan 8, 2025
driver-core/src/main/com/mongodb/client/model/bulk/BaseClientDeleteOptions.java
Show resolved
Hide resolved
Comment on lines
+30
to
+34
| BaseClientDeleteOptions collation(@Nullable Collation collation); | ||
|
|
||
| BaseClientDeleteOptions hint(@Nullable Bson hint); | ||
|
|
||
| BaseClientDeleteOptions hintString(@Nullable String hintString); |
There was a problem hiding this comment.
[optional]
- These three methods seem to be shared by all options, including replace options. It seems trivial to add
BaseClientWriteModelOptionsthat declares them, and is a super-interface forBaseClientDeleteOptions,BaseClientUpdateOptions,ClientReplaceOptions. upsertis shared byBaseClientUpdateOptionsandClientReplaceOptions. Do you think it makes sense to add something likeBaseClientUpsertableWriteModelOptions, such that it's a supertype forBaseClientUpdateOptionsandClientReplaceOptions?
driver-core/src/main/com/mongodb/internal/client/model/bulk/AbstractClientDeleteModel.java
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/client/model/bulk/ClientDeleteManyOptions.java
Show resolved
Hide resolved
driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedCrudHelper.java
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/client/model/bulk/ClientDeleteManyOptions.java
Show resolved
Hide resolved
stIncMale
reviewed
Jan 8, 2025
JAVA-5737
JAVA-5737
JAVA-5737
stIncMale
requested changes
Jan 9, 2025
driver-core/src/main/com/mongodb/internal/client/model/bulk/ConcreteClientUpdateManyModel.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/client/model/bulk/ConcreteClientUpdateOneModel.java
Outdated
Show resolved
Hide resolved
driver-core/src/test/unit/com/mongodb/MongoBaseInterfaceAssertions.java
Outdated
Show resolved
Hide resolved
driver-core/src/test/unit/com/mongodb/client/model/bulk/BaseClientDeleteOptionsTest.java
Outdated
Show resolved
Hide resolved
…ions.java Co-authored-by: Valentin Kovalenko <[email protected]>
…ncreteClientUpdateOneModel.java Co-authored-by: Valentin Kovalenko <[email protected]>
…ncreteClientUpdateManyModel.java Co-authored-by: Valentin Kovalenko <[email protected]>
JAVA-5737
JAVA-5737
stIncMale
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
BaseClientUpdateOptionsandBaseClientDeleteOptionsas shared base interfaces for their respective client option types. While duplication of methods in sub-interfaces is still required, this approach ensures a more error-resistant API evolution.JAVA-5737