Support native query without parameters #128

stIncMale · 2025-09-19T21:56:58Z

stIncMale · 2025-09-19T22:23:12Z

src/main/java/com/mongodb/hibernate/internal/type/ObjectIdJdbcType.java


    public static final ObjectIdJdbcType INSTANCE = new ObjectIdJdbcType();
-    public static final MqlType MQL_TYPE = MqlType.OBJECT_ID;
+    public static final SQLType MQL_TYPE = MqlType.OBJECT_ID;


I made MqlType package-access, as it does not need to be public.

TODO @stIncMale Rename the field to SQL_TYPE.

Done in 71c0d63.

stIncMale · 2025-09-19T22:24:54Z

src/main/java/com/mongodb/hibernate/dialect/MongoDialect.java

        typeContributions.contributeJavaType(ObjectIdJavaType.INSTANCE);
        typeContributions.contributeJdbcType(ObjectIdJdbcType.INSTANCE);
-        var objectIdTypeCode = MqlType.OBJECT_ID.getVendorTypeNumber();
+        var objectIdTypeCode = ObjectIdJdbcType.MQL_TYPE.getVendorTypeNumber();


MqlType was made package-access. Furthermore, ObjectIdJdbcType.MQL_TYPE explicitly points to our implementation of the JdbcType for ObjectId, which improves readability.

stIncMale · 2025-09-20T04:38:21Z

src/main/java/com/mongodb/hibernate/internal/type/ValueConversions.java

+        throw exceptionDomainTypeUnsupportedOrMustBeExplicit(value, domainType);
+    }
+
+    public static @Nullable Object toDomainValue(BsonValue value) throws SQLFeatureNotSupportedException {


This PR only needed this new method. However, I also wanted to stop using Object.class to represent "unknown domain type", which caused the rest of the changes.

stIncMale · 2025-09-20T23:21:11Z

src/integrationTest/java/com/mongodb/hibernate/query/select/NativeQueryIntegrationTests.java

+    @Table(name = COLLECTION_NAME)
+    @SqlResultSetMapping(
+            name = ItemWithFlattenedValue.MAPPING_FOR_FLATTENED_VALUE,
+            columns = {


I tried also using SqlResultSetMapping.classes, but I don't think Hibernate ORM implements that one correctly: instead of trying to find the corresponding constructor, it uses the no-argument constructor and then tries to populate the object, searching for the field/property based on the ColumnResult.name, which represents the column name, and does not have to match the name of a field/property.

stIncMale · 2025-09-30T02:01:14Z

src/integrationTest/java/com/mongodb/hibernate/ArrayAndCollectionIntegrationTests.java

    @Table(name = COLLECTION_NAME)
-    static class ItemWithArrayAndCollectionValues {
+    @SqlResultSetMapping(
+            name = ItemWithArrayAndCollectionValues.MAPPING_FOR_ITEM,


TODO @stIncMale File a ticket about creating a static helper method project(ItemWithArrayAndCollectionValues.class, ItemWithArrayAndCollectionValues.MAPPING_FOR_ITEM) that constructs the $project stage.

Done: https://jira.mongodb.org/browse/HIBERNATE-131

stIncMale · 2025-09-30T02:34:37Z

src/integrationTest/java/com/mongodb/hibernate/query/select/NativeQueryIntegrationTests.java

+     * queries</a>, {@link QueryProducer#createNativeQuery(String, Class)}.
+     */
+    @Test
+    void testScalar() {


TODO @stIncMale

Add

() -> { var mql = mql(COLLECTION_NAME, List.of(match(eq(itemWithNestedValue.id)), project(include("nested")))); assertEq( itemWithNestedValue.nested, session.createNativeQuery(mql, StructAggregateEmbeddableIntegrationTests.Plural.class).getSingleResult()); }

Done in ac23fc3.

HIBERNATE-60

vbabanin · 2025-10-16T00:39:56Z

src/integrationTest/java/com/mongodb/hibernate/query/select/NativeQueryIntegrationTests.java

+            if (fieldName.equals(ID_FIELD_NAME)) {
+                excludeId = true;
+            }


[nit/optional]

Suggested change

if (fieldName.equals(ID_FIELD_NAME)) {

excludeId = true;

}

excludeId |= ID_FIELD_NAME.equals(fieldName);

Done in 942a177.

vbabanin · 2025-10-17T06:10:32Z

src/integrationTest/java/com/mongodb/hibernate/query/select/NativeQueryIntegrationTests.java

+     * Returning DTOs (Data Transfer Objects)</a>, {@link QueryProducer#createNativeQuery(String, Class)}.
+     */
+    @Nested
+    class Dto {


As I see, Hibernate supports DTO mapping both via Tuple and directly to an instance of DTO class with the help of @ConstructorResult. I suggest adding tests for latter approach as well to have wider use-case coverage.

To keep things simple, we could add @ConstructorResult to existing entities used in these tests (e.g., BasicCrudIntegrationTests.Item, etc.) rather than introducing new DTO-only classes (it works in both cases). Then we could extend the Dto nested test class with constructor-based variants (e.g., testBasicValues that uses constructor mapping):

() -> assertEq( item, session.createNativeQuery(mql, Item.CONSTRUCTOR_MAPPING_FOR_ITEM, Item.class) .getSingleResult());

Findings so far: constructor mapping works with entities that have only basic types, embeddables, or structs. It fails with Collection or subtypes - Hibernate ORM throws a NullPointerException because CollectionJavaType returns a null as recommended type. If array is used in @ColumnResult for a parameter that is Collection, the parametrized constructor is not invoked and Hibernate falls back to using the default constructor and field mapping.

@Override public JdbcType getRecommendedJdbcType(JdbcTypeIndicators context) { // none return null; }

That looks like a Hibernate bug (regardless of whether collections are intended to be supported, given the non-descriptive error).

Given that, we can add/extend tests for:

ItemWithFlattenedValue ItemWithNestedValue ItemWithNestedValueHavingArraysAndCollections (collections are inside a struct, which our type handles) BasicCrudIntegrationTests.Item

Partially implemented suggestion (excludes ItemWithNestedValueHavingArraysAndCollections): 4fc30d2

Done in c78dcde. I based this commit on your commit (and there is credit for that), but I changed a fair bit.

Discussing it over Zoom may be faster.

HIBERNATE-60

Co-authored-by: Viacheslav Babanin <[email protected]>

stIncMale requested a review from vbabanin September 19, 2025 21:56

stIncMale self-assigned this Sep 19, 2025

stIncMale force-pushed the HIBERNATE-60 branch from 6572fbb to 72dd7e0 Compare September 19, 2025 21:59

stIncMale commented Sep 19, 2025

View reviewed changes

stIncMale commented Sep 20, 2025

View reviewed changes

stIncMale force-pushed the HIBERNATE-60 branch from 72dd7e0 to 510ae1f Compare September 20, 2025 04:43

stIncMale commented Sep 20, 2025

View reviewed changes

stIncMale force-pushed the HIBERNATE-60 branch 2 times, most recently from 02c39c7 to 51b953e Compare September 21, 2025 03:01

HIBERNATE-60

6fb9e8c

stIncMale force-pushed the HIBERNATE-60 branch from 51b953e to 6fb9e8c Compare September 21, 2025 03:08

stIncMale marked this pull request as ready for review September 29, 2025 21:26

stIncMale requested a review from a team as a code owner September 29, 2025 21:26

stIncMale commented Sep 30, 2025

View reviewed changes

Replace a Zulip link with a Hibernate ORM bug report link

ebf7051

HIBERNATE-60

vbabanin reviewed Oct 17, 2025

View reviewed changes

stIncMale and others added 2 commits October 20, 2025 21:16

Rename ObjectIdJdbcType.MQL_TYPE to SQL_TYPE

71c0d63

HIBERNATE-60

Add tests, refactor them

c78dcde

Co-authored-by: Viacheslav Babanin <[email protected]>

stIncMale force-pushed the HIBERNATE-60 branch from ac23fc3 to c78dcde Compare October 22, 2025 04:07

Use the technique of supreme people

942a177

stIncMale requested a review from vbabanin October 22, 2025 04:15

Merge branch 'main' into HIBERNATE-60

e1d2506

Support native query without parameters #128

Are you sure you want to change the base?

Support native query without parameters #128

Uh oh!

Conversation

stIncMale commented Sep 19, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vbabanin Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vbabanin Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stIncMale Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vbabanin Oct 16, 2025 •

edited

Loading

vbabanin Oct 17, 2025 •

edited

Loading

stIncMale Oct 22, 2025 •

edited

Loading