Add Instant support. #125

vbabanin · 2025-09-06T02:23:29Z

Hibernate ORM currently handles temporal types (Instant, etc.) inconsistently depending on where they appear in an entity. For example, saving an Instant of 10:15 (always UTC) on a host in GMT+1 leads to inconsistent results once read (tested with Postgres dialect):

top-level field -> 10:15 (correct)
array/collection element -> 09:15
struct field -> 11:15

This inconsistency makes it difficult to predict how temporal values will be stored and retrieved.

This PR ensures that temporal types are handled consistently in MongoDB extension across top-level fields, arrays/collections, and structs, so that serialization and deserialization behave uniformly regardless of context.

HIBERNATE-42

vbabanin · 2025-09-09T17:47:08Z

...ava/com/mongodb/hibernate/internal/extension/service/StandardServiceRegistryScopedState.java

+            Object enabled = configurationValues.get("hibernate.type.java_time_use_direct_jdbc");
+            if (enabled instanceof Boolean && (Boolean) enabled) {
+                throw new HibernateException(format(
+                        "Configuration property [%s] is incubating and not supported in MongoDB dialect",


Offline review with Valentin:
Remove "is incubating" and "Mongo dialect"

src/main/java/com/mongodb/hibernate/jdbc/MongoPreparedStatement.java

HIBERNATE-42

stIncMale

Submitting intermediate review results.

...ava/com/mongodb/hibernate/internal/extension/service/StandardServiceRegistryScopedState.java

src/main/java/com/mongodb/hibernate/dialect/MongoDialect.java

src/integrationTest/java/com/mongodb/hibernate/InstantIntegrationTests.java

src/integrationTest/java/com/mongodb/hibernate/embeddable/EmbeddableIntegrationTests.java

...ionTest/java/com/mongodb/hibernate/embeddable/StructAggregateEmbeddableIntegrationTests.java

src/integrationTest/java/com/mongodb/hibernate/BasicCrudIntegrationTests.java

src/integrationTest/java/com/mongodb/hibernate/jdbc/MongoPreparedStatementIntegrationTests.java

...va/com/mongodb/hibernate/query/select/temporal/AbstractSelectionTemporalIntegrationTest.java

src/main/java/com/mongodb/hibernate/jdbc/MongoPreparedStatement.java

stIncMale · 2025-09-24T23:12:15Z

The PR with all the proposed changes: vbabanin#1.

# Conflicts: # src/main/java/com/mongodb/hibernate/dialect/MongoDialect.java

- Add tests for the forbidden temporal types. - Use TimestampUtcAsInstantJdbcType. - Rename test method and display names. HIBERNATE-42

Add test case for flattened unsupported id types.

…onTests

stIncMale

The last reviewed commit is 62e3e2f.

src/integrationTest/java/com/mongodb/hibernate/type/temporal/InstantIntegrationTests.java

src/integrationTest/java/com/mongodb/hibernate/type/temporal/UnsupportedItems.java

...onTest/java/com/mongodb/hibernate/query/select/temporal/SelectionInstantIntegrationTest.java

...va/com/mongodb/hibernate/query/select/temporal/AbstractSelectionTemporalIntegrationTest.java

…nstantIntegrationTests.java Co-authored-by: Valentin Kovalenko <[email protected]>

…mporal/SelectionInstantIntegrationTest.java Co-authored-by: Valentin Kovalenko <[email protected]>

Add javadoc.

stIncMale

The last reviewed commit is 087a70b.

src/integrationTest/java/com/mongodb/hibernate/type/temporal/InstantIntegrationTests.java

...onTest/java/com/mongodb/hibernate/query/select/temporal/SelectionInstantIntegrationTest.java

...egrationTest/java/com/mongodb/hibernate/query/select/SortingSelectQueryIntegrationTests.java

src/integrationTest/java/com/mongodb/hibernate/type/temporal/UnsupportedItems.java

src/integrationTest/java/com/mongodb/hibernate/type/temporal/SqlTimeIntegrationTests.java

Add test-case.

stIncMale

The last reviewed commit is 101c1bf.

src/integrationTest/java/com/mongodb/hibernate/type/temporal/UnsupportedItems.java

vbabanin self-assigned this Sep 6, 2025

vbabanin requested a review from stIncMale September 6, 2025 02:47

vbabanin marked this pull request as ready for review September 9, 2025 06:22

vbabanin requested a review from a team as a code owner September 9, 2025 06:22

vbabanin commented Sep 9, 2025

View reviewed changes

src/main/java/com/mongodb/hibernate/jdbc/MongoPreparedStatement.java Outdated Show resolved Hide resolved

Add Instant support.

d7b51e5

HIBERNATE-42

vbabanin force-pushed the HIBERNATE-42-instant branch from ac167e0 to d7b51e5 Compare September 10, 2025 03:25

Move checks to HashSet.

2e2a975

stIncMale requested changes Sep 24, 2025

View reviewed changes

stIncMale mentioned this pull request Sep 24, 2025

Add Instant support. Review results vbabanin/mongo-hibernate#1

Closed

vbabanin added 7 commits October 9, 2025 18:20

Merge branch 'main' into HIBERNATE-42-instant

be88c31

# Conflicts: # src/main/java/com/mongodb/hibernate/dialect/MongoDialect.java

- Use Set.of in MongoAdditionalMappingContributor.

4544c8b

- Add tests for the forbidden temporal types. - Use TimestampUtcAsInstantJdbcType. - Rename test method and display names. HIBERNATE-42

Fix MongoDialect.

a1cec53

Add test case for flattened unsupported id types.

Revert optional table update operation in MongoDialect.

ee14321

Add appendDatetimeFormat.

328994e

Remove JdbcTypeCode annotation from Instant field in InstantIntegrati…

023b867

…onTests

Refactor tests.

09fc9a4

vbabanin requested a review from stIncMale October 15, 2025 20:47

Merge branch 'main' into HIBERNATE-42-instant

62e3e2f

stIncMale requested changes Oct 20, 2025

View reviewed changes

vbabanin and others added 5 commits October 20, 2025 12:34

Update src/integrationTest/java/com/mongodb/hibernate/type/temporal/I…

3311fd7

…nstantIntegrationTests.java Co-authored-by: Valentin Kovalenko <[email protected]>

Update src/integrationTest/java/com/mongodb/hibernate/query/select/te…

240799e

…mporal/SelectionInstantIntegrationTest.java Co-authored-by: Valentin Kovalenko <[email protected]>

Refactor MongoContributor.

8c41fb8

Add javadoc.

Merge branch 'main' into HIBERNATE-42-instant

789a469

Rename entities.

087a70b

vbabanin requested a review from stIncMale October 21, 2025 21:01

stIncMale requested changes Oct 22, 2025

View reviewed changes

Change javadoc.

101c1bf

Add test-case.

stIncMale requested changes Oct 23, 2025

View reviewed changes

src/integrationTest/java/com/mongodb/hibernate/type/temporal/UnsupportedItems.java Outdated Show resolved Hide resolved

vbabanin added 4 commits October 23, 2025 08:01

Use "component type of the array" for clarity in the javadoc.

a0f8de1

Apply spotless to Javadoc.

3289cd6

Name fix.

3bc384d

Merge branch 'main' into HIBERNATE-42-instant

136d768

vbabanin requested a review from stIncMale October 23, 2025 16:27

stIncMale approved these changes Oct 23, 2025

View reviewed changes

vbabanin merged commit 193c5c7 into mongodb:main Oct 23, 2025
7 checks passed

Add Instant support. #125

Add Instant support. #125

Uh oh!

Conversation

vbabanin commented Sep 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vbabanin Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

stIncMale left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stIncMale commented Sep 24, 2025

Uh oh!

stIncMale left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stIncMale left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stIncMale left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vbabanin commented Sep 6, 2025 •

edited

Loading

vbabanin Sep 9, 2025 •

edited

Loading