-
Notifications
You must be signed in to change notification settings - Fork 919
GODRIVER-3523 Drop support for MongoDB 4.0. #2221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🧪 Performance ResultsCommit SHA: 0ce103eThe following benchmark tests for version 68e6e20231536c0007d047c8 had statistically significant changes (i.e., |z-score| > 1.96):
For a comprehensive view of all microbenchmark results for this PR's commit, please check out the Evergreen perf task for this patch. |
f1640e0
to
27a1d43
Compare
API Change ReportNo changes found! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request drops support for MongoDB 4.0, updating the minimum supported MongoDB version to 4.2.
- Updated minimum wire version from 7 (MongoDB 4.0) to 8 (MongoDB 4.2)
- Removed version checks and constraints for MongoDB 4.0 throughout the codebase
- Added skip entries for pre-4.2 SDAM tests that are no longer relevant
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
x/mongo/driver/topology/topology_test.go | Updated error message to reflect new minimum wire version requirement |
x/mongo/driver/topology/sdam_spec_test.go | Added CheckSkip call to skip irrelevant pre-4.2 tests |
x/mongo/driver/topology/fsm.go | Updated MinSupportedMongoDBVersion constant from "4.0" to "4.2" |
x/mongo/driver/integration/scram_test.go | Removed MongoDB 4.0 version check and unused import |
mongo/options/listcollectionsoptions.go | Removed MongoDB 4.0 version constraint from documentation |
mongo/options/changestreamoptions.go | Removed MongoDB 4.0 version constraint from documentation |
internal/spectest/skip.go | Added skip entries for pre-4.2 SDAM tests |
internal/integration/sdam_error_handling_test.go | Removed MongoDB 4.0 version constraints from test options |
internal/integration/primary_stepdown_test.go | Simplified test cases by removing version constraints |
internal/integration/change_stream_test.go | Removed MongoDB 4.0 specific test cases and helper functions |
internal/driverutil/description.go | Updated MinWireVersion constant from 7 to 8 |
internal/docexamples/examples_test.go | Simplified causal consistency examples by removing version filtering |
README.md | Updated documentation to reflect MongoDB 4.2 as minimum version |
.evergreen/config.yml | Removed MongoDB 4.0 build variants from CI configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
GODRIVER-3523
Summary
Drop support for MongoDB 4.0.
Background & Motivation