CXX-2656 Update tests for QEv2 compatibility #953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkloberdanz
approved these changes
Apr 10, 2023
kevinAlbs
approved these changes
Apr 10, 2023
Collaborator
kevinAlbs
left a comment
kevinAlbs
left a comment
There was a problem hiding this comment.
LGTM with a change to a test skip condition.
| // CXX-2656: temporarily workaround "payload type that is no longer supported" errors until the | ||
| // QEv2 protocol is properly supported. | ||
| if (test_util::newer_than(conn, "7.0")) { | ||
| WARN("Skipping - skipping tests that require QEv2 (CXX-2656)"); | ||
| return; | ||
| } |
Collaborator
There was a problem hiding this comment.
Prose tests that require Queryable Encryption are expected to require server version 7.0 or newer.
Suggest replacing this if block and the one above with:
if (!test_util::newer_than(conn, "7.0")) {
WARN("Skipping - MongoDB server 7.0 or newer required");
return;
}
Contributor
Author
|
Latest changes verified by this patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves CXX-2656. Verified by this patch.
Resolves current Evergreen task failures when testing against latest replica sets due to the following error:
Legacy CSE Tests
This PR moves legacy CSE tests into a proper
legacysubdirectory for consistency with other unified spec tests with legacy/unified components. Updated CSE test environment variables accordingly.CXX-2656 Test Files
This PR syncs the legacy test files with mongodb/specifications@64deb28 with the exception of the following files:
Minimum libmongoc Version
Bumped to mongodb/mongo-c-driver@8aced03 to include dependent changes introduced by mongodb/mongo-c-driver#1228, including use of libmongocrypt 1.8.0-alpha0.
Snapshot Documentation Examples
This PR also introduces a skip condition for snapshot documentation examples. See CXX-2671 for details.
Miscellaneous
Improved quality of error messages on unexpected test operation success (when an error was expected instead) by emitting the result of the successful command.