Address miscellaneous GCC and Clang warnings#1582
Merged
eramongodb merged 2 commits intomongodb:masterfrom Feb 13, 2026
Merged
Conversation
kevinAlbs
approved these changes
Feb 13, 2026
eramongodb
force-pushed
the
cxx-warnings
branch
from
1f08bb6 to
ff78638
Compare
Contributor
Author
|
Whoops, excuse the rebase. Was trying to push #1583. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #1577 and #1579 where:
class encrypt_opts_deleterwere emitting-Wunused-member-functionClang warnings, andfor (auto const& e : a.b().c())pattern was (understandably) triggering false-positive-Wdangling-referenceGCC warnings due to risk of returning a reference/view to a temporary object (not actually the case here, but nevertheless).