v1: delete_many_options and delete_one_options (CXX-3237, CXX-3238) #1527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
approved these changes
Dec 4, 2025
Collaborator
kevinAlbs
left a comment
kevinAlbs
left a comment
There was a problem hiding this comment.
LGTM with comment fix-ups.
| /// | ||
| /// Convert to the @ref mongocxx::v_noabi equivalent of `v`. | ||
| /// | ||
| /// @note The `ordered` field is initialized as unset. |
Collaborator
There was a problem hiding this comment.
Remove non-applicable comment:
Suggested change
| /// @note The `ordered` field is initialized as unset. |
| return {std::move(v)}; | ||
| } | ||
|
|
||
| // Ambiguous whether `v_noabi::options::delete` should be converted to `v1::delete_many_options` or |
Collaborator
There was a problem hiding this comment.
Suggested change
| // Ambiguous whether `v_noabi::options::delete` should be converted to `v1::delete_many_options` or | |
| // Ambiguous whether `v_noabi::options::delete_options` should be converted to `v1::delete_many_options` or |
Comment on lines
301
to
302
| // v1::delete_many_options to_v1(v_noabi::options::delete const& v); | ||
| // v1::delete_one_options to_v1(v_noabi::options::delete const& v); |
Collaborator
There was a problem hiding this comment.
Suggested change
| // v1::delete_many_options to_v1(v_noabi::options::delete const& v); | |
| // v1::delete_one_options to_v1(v_noabi::options::delete const& v); | |
| // v1::delete_many_options to_v1(v_noabi::options::delete_options const& v); | |
| // v1::delete_one_options to_v1(v_noabi::options::delete_options const& v); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves CXX-3237 and CXX-3238 for the
v1::delete_many_optionsandv1::delete_one_optionscomponents.The
to_v1()helper is not supported due to ambiguity (many vs. one): an explicit cast to the target type is required. This is similar tobsoncxx::v1::element::viewwhich lacks afrom_v1()to eitherv_noabi::array::elementorv_noabi::document::elementdue to ambiguity.