Skip to content

Conversation

@eramongodb
Copy link
Contributor

@eramongodb eramongodb commented Sep 18, 2025

Followup to #1412, where the documentation of post-move state for v1::document::value (and v1::array::value via \copydoc) was not correctly updated to account for the default initialization state being changed from "invalid" to "empty", as asserted by the (correctly updated) tests:

SECTION("move") {
auto const move = std::move(v);
CHECK(v.data() == nullptr);
CHECK_NOFAIL(!v.get_deleter()); // Valid but unspecified state.
CHECK(move.data() == empty.data());
CHECK(get_deleter<noop_deleter_type>(move) == noop_deleter);
}

@eramongodb eramongodb self-assigned this Sep 18, 2025
@eramongodb eramongodb requested a review from a team as a code owner September 18, 2025 20:06
@eramongodb eramongodb merged commit b224074 into mongodb:master Sep 18, 2025
3 of 4 checks passed
@eramongodb eramongodb deleted the cxx-abi-v1-bsoncxx branch September 18, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants