CXX-3323 drop support for MongoDB Server 4.0 or older#1436
Merged
eramongodb merged 3 commits intomongodb:masterfrom Aug 4, 2025
Merged
CXX-3323 drop support for MongoDB Server 4.0 or older#1436eramongodb merged 3 commits intomongodb:masterfrom
eramongodb merged 3 commits intomongodb:masterfrom
Conversation
kevinAlbs
approved these changes
Aug 4, 2025
Collaborator
There was a problem hiding this comment.
LGTM with some suggested additional removals:
- Calls
test_util::newer_than(which may be better named totest_util::equal_or_newer_than) for "4.2" and older. This check forcommitQuorumsupport.
Contributor
Author
Opted for
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves CXX-3323. Followup to #1429 and #1434.
#1434 already added the corresponding CHANGELOG entry and removed related EVG tasks.
Scans the codebase for all instances of MongoDB Server version checks against a value that corresponds to 4.0 or older and removes them. Most of these are in test code, but there are a few bits of library code as well, such as in
mongocxx::v_noabi::collection::_drop()and an obsolete doc comment formongocxx::v_noabi::result::bulk_write::modified_count().