CDRIVER-2813 Remove ENABLE_EXTRA_ALIGNMENT (CXX-3260)#1364
Merged
eramongodb merged 4 commits intomongodb:masterfrom Apr 1, 2025
Merged
CDRIVER-2813 Remove ENABLE_EXTRA_ALIGNMENT (CXX-3260)#1364eramongodb merged 4 commits intomongodb:masterfrom
eramongodb merged 4 commits intomongodb:masterfrom
Conversation
eramongodb
changed the title
eramongodb
changed the title
kevinAlbs
approved these changes
Apr 1, 2025
Collaborator
kevinAlbs
left a comment
kevinAlbs
left a comment
There was a problem hiding this comment.
LGTM. Satisfying to see the reduced test matrix and workaround removals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to mongodb/mongo-c-driver#1942.
Partially reverts the changes in #1329 pertaining to dynamic allocation of types inheriting extended alignment requirements (e.g.
bson_t->bsoncxx::aligned_storage<bson_t>). Changes pertaining to handling of ignored attributes for template parameters are still necessary. All EVG task coverage specific to configuration withENABLE_EXTRA_ALIGNMENTare removed.