Fix polyfill selection for compile tasks + use large distros #1243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
approved these changes
Oct 29, 2024
Collaborator
kevinAlbs
left a comment
kevinAlbs
left a comment
There was a problem hiding this comment.
Thank you for the fix. LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified by this patch.
#1194 added the RHEL 7.9 distro to test against GCC 4.8.5 and the bsoncxx polyfill impls via
BSONCXX_POLYFILL: impls. However, the"compile"EVG function doesn't know about this env var, as it is only used by the scan-build tasks. Therefore, the task has actually been compiling against mnmlstc/core instead.This PR extends the
BSONCXX_POLYFILLpattern to the"compile"EVG function andcompile.shscript for consistency, replacing theUSE_POLYFILL_BOOSTenv var. The task now compiles with bsoncxx impls as intended. This revealed some compilation errors due to unused named parameters inoptional.hpp, which this PR also addresses.As a drive-by improvement, this PR also moves all compile/build/etc. tasks to large distro variants to reduce task execution times.