CSHARP-5202: BSON Binary Vector Subtype Support #1581
Conversation
BorisDog
requested review from
JamesKovacs,
papafe and
sanych-sun
and removed request for
a team and
JamesKovacs
| } | ||
|
|
||
| /// <summary> | ||
| /// Represents a vector of bit values. |
There was a problem hiding this comment.
Should we use the term "packed bit"?
src/MongoDB.Bson/Serialization/Serializers/BsonVectorSerializer.cs
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| /// <summary> | ||
| /// Represents a serializer for <see cref="BsonVectorToCollectionSerializer{TItemCollection, T}"/>. |
There was a problem hiding this comment.
I think this is the wrong type
| _ => throw new ArgumentOutOfRangeException(nameof(bsonVectorDataType), bsonVectorDataType, "Unsupported vector datatype.") | ||
| }; | ||
|
|
||
| if (!supportedTypes.Contains(typeof(T))) |
There was a problem hiding this comment.
Isn't supportedTypes always a list with one element? Do we expect it to change?
There was a problem hiding this comment.
Good question, I think we should plan to support other types of avoid double conversion.
But for now I've removed the array, so we don't have such "dead code".
| } | ||
| else | ||
| { | ||
| throw new NotSupportedException("Little Endian architecture is not supported yet."); |
There was a problem hiding this comment.
I think this exception should be referencing "Big Endian" instead?
| { | ||
| case BsonVectorDataType.Float32: | ||
| { | ||
| if (elements is not float[] floatArray) |
There was a problem hiding this comment.
Isn't this already verified by the Validate method?
There was a problem hiding this comment.
Technically yes. But for minimizing the chance for future bugs and for completeness, I'd prefer to validate the input again.
Also technically this method can be reused outside the current scope and decoupled from ValidateDataType.
Made it private.
Co-authored-by: Ferdinando Papale <[email protected]>
No description provided.