Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSHARP-5348: Avoid allocations for Bson*Context #1509

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

CSHARP-5348: Avoid allocations for Bson*Context #1509

wants to merge 3 commits into from

Conversation

obligaron
Copy link
Contributor

See CSHARP-5348 for details.

This PR is split into three commits

  • First, adds PopContext if it is missing from Bson*Context (no logic change)
  • Second, adds a PushContext method (no logic change)
  • The third adds the caching logic to Bson*Context.

If the first and second commits should be separated, I can reduce the PR to just the caching logic. For our environment, the BsonBinaryReader/BsonBinaryWriter are also the most important ones.

@obligaron obligaron requested a review from a team as a code owner October 21, 2024 20:32
@obligaron obligaron requested review from adelinowona and removed request for a team October 21, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adelinowona adelinowona Awaiting requested review from adelinowona adelinowona is a code owner automatically assigned from mongodb/dbx-csharp-dotnet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@obligaron