CSHARP-5349: Code review changes.

mongodb · Nov 15, 2024 · bed9e9b · bed9e9b
1 parent c2c3cfd
commit bed9e9b
Showing 1 changed file with 7 additions and 9 deletions.
diff --git a/src/MongoDB.Bson/Serialization/BsonSerializer.cs b/src/MongoDB.Bson/Serialization/BsonSerializer.cs
@@ -274,9 +274,9 @@ internal static IDiscriminatorConvention GetOrRegisterDiscriminatorConvention(Ty
             __configLock.EnterReadLock();
             try
             {
-                if (__discriminatorConventions.TryGetValue(type, out var registeredConvention))
+                if (__discriminatorConventions.TryGetValue(type, out var registeredDiscriminatorConvention))
                 {
-                    return registeredConvention;
+                    return registeredDiscriminatorConvention;
                 }
             }
             finally
@@ -287,15 +287,13 @@ internal static IDiscriminatorConvention GetOrRegisterDiscriminatorConvention(Ty
             __configLock.EnterWriteLock();
             try
             {
-                if (__discriminatorConventions.TryGetValue(type, out var registeredConvention))
+                if (__discriminatorConventions.TryGetValue(type, out var registeredDiscrimantorConvention))
                 {
-                    return registeredConvention;
-                }
-                else
-                {
-                    RegisterDiscriminatorConvention(type, discriminatorConvention);
-                    return discriminatorConvention;
+                    return registeredDiscrimantorConvention;
                 }
+
+                RegisterDiscriminatorConvention(type, discriminatorConvention);
+                return discriminatorConvention;
             }
             finally
             {