Use Artifactory to obtain Docker images #1794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
approved these changes
Nov 18, 2024
Collaborator
kevinAlbs
left a comment
kevinAlbs
left a comment
There was a problem hiding this comment.
LGTM, and thank you. This reminded me the step to authenticate was needed. Updated the libmongocrypt PR accordingly.
kevinAlbs
added a commit
to kevinAlbs/libmongocrypt
that referenced
this pull request
Nov 18, 2024
To avoid "not implemented" error referenced in mongodb/mongo-c-driver#1794
kevinAlbs
added a commit
to mongodb/libmongocrypt
that referenced
this pull request
Nov 18, 2024
* replace dockerhub references with artifactory * install `make` to build clang-format * remove ubuntu2004 from docker distros. * Avoids "not implemented" error referenced in mongodb/mongo-c-driver#1794 * replace ubuntu1804 with ubuntu2204 in docker distros * Agrees with Evergreen distro best practices. * pass `--persist-build=false` to avoid internal use of Docker Hub
joshbsiegel
pushed a commit
to joshbsiegel/libmongocrypt
that referenced
this pull request
Nov 18, 2024
* replace dockerhub references with artifactory * install `make` to build clang-format * remove ubuntu2004 from docker distros. * Avoids "not implemented" error referenced in mongodb/mongo-c-driver#1794 * replace ubuntu1804 with ubuntu2204 in docker distros * Agrees with Evergreen distro best practices. * pass `--persist-build=false` to avoid internal use of Docker Hub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified by this patch.
Appends a
docker logincommand prior to Earthly/Docker commands and uses the custom Earthly buildkit image intools/earthly.shas done in mongodb/libmongocrypt#911.The Ubuntu 20.04 distro is dropped from the list due to the following obtuse error: